openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
397 stars 607 forks source link

CONSOLE-4287: Restore kubevirt extensions for the topology plugin #14360

Open pcbailey opened 2 days ago

pcbailey commented 2 days ago

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CONSOLE-4287

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

openshift-ci-robot commented 2 days ago

@pcbailey: This pull request references CNV-45158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/CNV-45158 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 days ago

@pcbailey: This pull request references CNV-45158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/OCPBUGS-42672 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 days ago

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/OCPBUGS-42672 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 2 days ago

/jira refresh

openshift-ci-robot commented 2 days ago

@upalatucci: This pull request references Jira Issue OCPBUGS-42672, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14360#issuecomment-2388369798): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pcbailey commented 2 days ago

/jira refresh

openshift-ci-robot commented 2 days ago

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14360#issuecomment-2388879529): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 day ago

@pcbailey: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
upalatucci commented 1 day ago

/lgtm

upalatucci commented 1 day ago

/approve

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pcbailey, upalatucci Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)** - **[pkg/OWNERS](https://github.com/openshift/console/blob/master/pkg/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pcbailey, upalatucci Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)** - **[pkg/OWNERS](https://github.com/openshift/console/blob/master/pkg/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 20 hours ago

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/CONSOLE-4287 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 20 hours ago

@pcbailey: This pull request references CONSOLE-4287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/CONSOLE-4287 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.