openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
402 stars 615 forks source link

CONSOLE-4287: Restore kubevirt extensions for the topology plugin #14360

Open pcbailey opened 1 month ago

pcbailey commented 1 month ago

This PR restores kubevirt extensions for topology.

Jira: https://issues.redhat.com/browse/CONSOLE-4287

Screenshots

Before

restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33

After

restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04

openshift-ci-robot commented 1 month ago

@pcbailey: This pull request references CNV-45158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/CNV-45158 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@pcbailey: This pull request references CNV-45158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/OCPBUGS-42672 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/OCPBUGS-42672 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@upalatucci: This pull request references Jira Issue OCPBUGS-42672, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14360#issuecomment-2388369798): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pcbailey commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14360#issuecomment-2388879529): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 1 month ago

/lgtm

upalatucci commented 1 month ago

/approve

openshift-ci-robot commented 1 month ago

@pcbailey: This pull request references Jira Issue OCPBUGS-42672, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/CONSOLE-4287 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@pcbailey: This pull request references CONSOLE-4287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/CONSOLE-4287 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jhadvig commented 3 weeks ago

Docs Approver: /assign @opayne1 PX Approver: /assign @reestr QA Approver: /assign @yapei

yapei commented 3 weeks ago

VirtualMachines can be shown in topology view but I'm consistently seeing Uncaught runtime errors when navigating through virtualization pages, here is one recording I'm running following bridge commands locally

./bin/bridge -plugins kubevirt-plugin=http://localhost:9001 -i18n-namespaces=plugin__kubevirt-plugin

https://github.com/user-attachments/assets/6dbcf3e4-6604-4ad8-98f6-8e5c103119ab

upalatucci commented 2 weeks ago

@yapei i think this pr is not correlated to the error. We are experiencing the issue even on console latest

yapei commented 2 weeks ago

Thanks @upalatucci You are right, I tried on latest console master and see the same error Regarding this PR changes, everything looks good so far Screenshot 2024-11-14 at 10 12 47 AM /label qe-approved

openshift-ci-robot commented 2 weeks ago

@pcbailey: This pull request references CONSOLE-4287 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14360): >This PR restores kubevirt extensions for topology. > >Jira: https://issues.redhat.com/browse/CONSOLE-4287 > >## Screenshots > >### Before > >![restore-kubevirt-topology-extensions--BEFORE--2024-10-01_21-33](https://github.com/user-attachments/assets/7bdcd8cb-fa50-453a-bfae-36130e35325e) > >### After > >![restore-kubevirt-topology-extensions--AFTER--2024-10-01_16-04](https://github.com/user-attachments/assets/94aee3ba-0461-4c63-af00-c714e501beed) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 4 days ago

/lgtm

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pcbailey, upalatucci Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)** - **[pkg/OWNERS](https://github.com/openshift/console/blob/master/pkg/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pcbailey commented 4 days ago

/retest

openshift-ci[bot] commented 3 days ago

New changes are detected. LGTM label has been removed.

pcbailey commented 3 days ago

/retest

pcbailey commented 3 days ago

/retest

pcbailey commented 2 days ago

/retest

openshift-ci[bot] commented 2 days ago

@pcbailey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 3711702dfa016dd77fb923d3ea4f63904a4486e6 link true /test e2e-gcp-console
ci/prow/okd-scos-e2e-aws-ovn 3711702dfa016dd77fb923d3ea4f63904a4486e6 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).