openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
402 stars 615 forks source link

ODC-7680: Remove `SeriesButton`, `QueryTable` #14363

Closed logonoff closed 1 month ago

logonoff commented 1 month ago

Fixes:

https://issues.redhat.com/browse/ODC-7680

Solution Description:

SeriesButton and QueryTable do not appear to be used anywhere within the openshift/console and openshift/monitoring-plugin repos, and QueryTable is using deprecated PatternFly Table components

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

unchanged

Test setup:

n/a

Browser conformance:

This pr is 3/4 of ODC-7680 story as each file is being split into a separate PR.

openshift-ci-robot commented 1 month ago

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14363): >**Fixes**: > >https://issues.redhat.com/browse/ODC-7680 > >**Solution Description**: > >`SeriesButton` and `QueryTable` do not appear to be used anywhere within the openshift/console and openshift/monitoring-plugin repos, and `QueryTable` is using deprecated PatternFly Table components > >**Screen shots / Gifs for design review**: > > >n/a > >**Unit test coverage report**: > >unchanged > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > >This pr is 3/4 of [ODC-7680](https://issues.redhat.com//browse/ODC-7680) story as each file is being split into a separate PR. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14363): >**Fixes**: > >https://issues.redhat.com/browse/ODC-7680 > >**Solution Description**: > >`SeriesButton` and `QueryTable` do not appear to be used anywhere within the [openshift/console](https://github.com/openshift/console/) and [openshift/monitoring-plugin](https://github.com/openshift/monitoring-plugin/) repos, and `QueryTable` is using deprecated PatternFly Table components > >**Screen shots / Gifs for design review**: > > >n/a > >**Unit test coverage report**: > >unchanged > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > >This pr is 3/4 of [ODC-7680](https://issues.redhat.com//browse/ODC-7680) story as each file is being split into a separate PR. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14363#issuecomment-2389572424): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 month ago

/retest

kyoto commented 1 month ago

CC @jgbernalp, @zhuje, @PeterYurkovich

Is it OK to remove these now?

zhuje commented 1 month ago

okay to remove

jgbernalp commented 1 month ago

/lgtm

logonoff commented 1 month ago

adding labels because this is debt

/label px-approved /label docs-approved

logonoff commented 1 month ago

/retest

jgbernalp commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sanketpathak commented 1 month ago

Verified on cluster with admin and non-admin user Screenshot from 2024-10-17 20-22-55 /label qe-approved

openshift-ci-robot commented 1 month ago

@logonoff: This pull request references ODC-7680 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14363): >**Fixes**: > >https://issues.redhat.com/browse/ODC-7680 > >**Solution Description**: > >`SeriesButton` and `QueryTable` do not appear to be used anywhere within the [openshift/console](https://github.com/openshift/console/) and [openshift/monitoring-plugin](https://github.com/openshift/monitoring-plugin/) repos, and `QueryTable` is using deprecated PatternFly Table components > >**Screen shots / Gifs for design review**: > > >n/a > >**Unit test coverage report**: > >unchanged > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > >This pr is 3/4 of [ODC-7680](https://issues.redhat.com//browse/ODC-7680) story as each file is being split into a separate PR. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.