search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
402 stars 615 forks source link

OCPBUGS-43799: Debounce tile view searches #14365

Closed logonoff closed 1 month ago

logonoff commented 1 month ago

Fixes:

Fixes: https://issues.redhat.com/browse/OCPBUGS-43799

Analysis / Root cause:

when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke

Solution Description:

debounce for 300ms

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

openshift-ci-robot commented 1 month ago

@logonoff: This pull request references ODC-7705 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14365): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/ODC-7705 > >**Analysis / Root cause**: > >when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke > >**Solution Description**: > >debounce for 500ms > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x ] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references ODC-7705 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14365): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/ODC-7705 > >**Analysis / Root cause**: > >when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke > >**Solution Description**: > >debounce for 300ms > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x ] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references ODC-7705 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14365): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/ODC-7705 > >**Analysis / Root cause**: > >when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke > >**Solution Description**: > >debounce for 300ms > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 month ago

/cc @vikram-raj

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references Jira Issue OCPBUGS-43799, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14365): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/ODC-7705 > >**Analysis / Root cause**: > >when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke > >**Solution Description**: > >debounce for 300ms > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 9343d18802026bc976bb48f56c0c884806e3c85d and 2 for PR HEAD a5d55844c8de661c1ee87a32a5f9e0d6541a36b8 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 9343d18802026bc976bb48f56c0c884806e3c85d and 2 for PR HEAD a5d55844c8de661c1ee87a32a5f9e0d6541a36b8 in total

openshift-ci[bot] commented 1 month ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@logonoff: Jira Issue OCPBUGS-43799: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43799 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14365): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/OCPBUGS-43799 > >**Analysis / Root cause**: > >when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke > >**Solution Description**: > >debounce for 300ms > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410251041.p0.g830a524.assembly.stream.el9. All builds following this will include this PR.