openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
397 stars 607 forks source link

ODC-7705: Debounce tile view searches #14365

Open logonoff opened 1 day ago

logonoff commented 1 day ago

Fixes:

Fixes: https://issues.redhat.com/browse/ODC-7705

Analysis / Root cause:

when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke

Solution Description:

debounce for 300ms

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

n/a

Browser conformance:

openshift-ci-robot commented 1 day ago

@logonoff: This pull request references ODC-7705 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14365): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/ODC-7705 > >**Analysis / Root cause**: > >when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke > >**Solution Description**: > >debounce for 500ms > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x ] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff Once this PR has been reviewed and has the lgtm label, please assign invinciblejai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 day ago

@logonoff: This pull request references ODC-7705 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14365): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/ODC-7705 > >**Analysis / Root cause**: > >when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke > >**Solution Description**: > >debounce for 300ms > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x ] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 day ago

@logonoff: This pull request references ODC-7705 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14365): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/ODC-7705 > >**Analysis / Root cause**: > >when searching in tile catalogs such as OperatorHub or the Samples catalog, the input is not debounced so all the filtering logic happens on each keystroke > >**Solution Description**: > >debounce for 300ms > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >n/a > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 day ago

/cc @vikram-raj

openshift-ci[bot] commented 22 hours ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).