search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
397 stars 607 forks source link

OCPBUGS-41904: fix annotation for ovn localnet #14366

Open upalatucci opened 1 day ago

upalatucci commented 1 day ago

Do not add annotations for ovn localnet. So make sure typeParamsData has resourceName.value or bridge.value . In case of ovn localnet does not have those fields.

openshift-ci-robot commented 1 day ago

@upalatucci: This pull request references Jira Issue OCPBUGS-41904, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14366): >Do not add annotations for ovn localnet. >So make sure `typeParamsData` has `resourceName.value` or `bridge.value` . In case of ovn localnet does not have those fields. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 1 day ago

/jira refresh

openshift-ci-robot commented 1 day ago

@upalatucci: This pull request references Jira Issue OCPBUGS-41904, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console/pull/14366#issuecomment-2391267719): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pcbailey commented 1 day ago

/lgtm

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/network-attachment-definition-plugin/OWNERS](https://github.com/openshift/console/blob/release-4.16/frontend/packages/network-attachment-definition-plugin/OWNERS)~~ [pcbailey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
upalatucci commented 1 day ago

/jira refresh

openshift-ci-robot commented 1 day ago

@upalatucci: This pull request references Jira Issue OCPBUGS-41904, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console/pull/14366#issuecomment-2391390358): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 1 day ago

/jira refresh

openshift-ci-robot commented 1 day ago

@upalatucci: This pull request references Jira Issue OCPBUGS-41904, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console/pull/14366#issuecomment-2391520136): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 1 day ago

/jira refresh

openshift-ci-robot commented 1 day ago

@upalatucci: This pull request references Jira Issue OCPBUGS-41904, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-42735](https://issues.redhat.com//browse/OCPBUGS-42735) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42735](https://issues.redhat.com//browse/OCPBUGS-42735) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14366#issuecomment-2391521014): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 23 hours ago

/retest

openshift-ci[bot] commented 22 hours ago

@upalatucci: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console a648aa81363acfe05e7917ba5a2c4a7b01f01f5d link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).