search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
402 stars 615 forks source link

CONSOLE-3905: (deps) upgrade to webpack 5 #14378

Open logonoff opened 1 month ago

logonoff commented 1 month ago

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3905

Solution description

Reviewers and assignees:

n/a

Test cases:

Additional info:

n/a

Screen shots / gifs / design review:

n/a

openshift-ci-robot commented 1 month ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> >- upgraded webpack and related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated > >

Reviewers and assignees:

> > >

Test cases:

> >n/a > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack and related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated > >

Reviewers and assignees:

> > >

Test cases:

> >n/a > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 month ago

/retest e2e-gcp-console

openshift-ci[bot] commented 1 month ago

@logonoff: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/console/pull/14378#issuecomment-2395166499): >/retest e2e-gcp-console Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack and related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > >

Test cases:

> >n/a > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack and related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > >

Test cases:

> >n/a > >

Additional info:

> > >[wip] I have some runtime errors, such as `_TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefined` and `can't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization`, which seem to suggest there are some cyclical imports which I'm not really sure how to deal with > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack related dependencies to latest version >- upgraded webpack to 5.75 to match plugins >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > >

Test cases:

> >n/a > >

Additional info:

> > >[wip] I have some runtime errors, such as `_TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefined` and `can't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization`, which seem to suggest there are some cyclical imports which I'm not really sure how to deal with > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > >

Test cases:

> >n/a > >

Additional info:

> > >[wip] I have some runtime errors, such as `_TopologyPage__WEBPACK_IMPORTED_MODULE_5__ is undefined` and `can't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization`, which seem to suggest there are some cyclical imports which I'm not really sure how to deal with > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff Once this PR has been reviewed and has the lgtm label, please assign invinciblejai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > >

Test cases:

> >n/a > >

Additional info:

> > > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > >

Test cases:

> >n/a > >

Additional info:

> >n/a > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > >

Test cases:

> >- Does `@console/internal/file-input` still work as expected? >- Are there any regressions with `formik` or `react-dnd`? >- Do all the Monaco YAML language server features work? >- Does everything else feel the exact same? > >

Additional info:

> >n/a > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > > > >

Test cases:

> >- Does `@console/internal/file-input` still work as expected? >- Are there any regressions with `formik` or `react-dnd`? >- Do all the Monaco YAML language server features work? >- Does everything else feel the exact same? > >

Additional info:

> >n/a > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error > >

Reviewers and assignees:

> > > >n/a > > >

Test cases:

> >- Does `@console/internal/file-input` still work as expected? >- Are there any regressions with `formik` or `react-dnd`? >- Do all the Monaco YAML language server features work? >- Does everything else feel the exact same? > >

Additional info:

> >n/a > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded webpack related dependencies to latest version >- updated formik from 2.0.3 to 2.1.5 to fix build warning >- remove cache-loader, null-loader because they are deprecated >- updated react-dnd from 9.4.0 to 11.1.3 to fix build error >- switched ts-loader to esbuild-loader for performance > >

Reviewers and assignees:

> > > >n/a > > >

Test cases:

> >- Does `@console/internal/file-input` still work as expected? >- Are there any regressions with `formik` or `react-dnd`? >- Do all the Monaco YAML language server features work? >- Does everything else feel the exact same? > >

Additional info:

> >n/a > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-3905 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14378): >

CONSOLE Features and Fixes:

> > >https://issues.redhat.com/browse/CONSOLE-3905 > >

Solution description

> > >- upgraded `webpack` related dependencies to latest version >- updated `formik` from 2.0.3 to 2.1.5 to fix build warning >- remove `cache-loader`, `null-loader` because they are deprecated >- updated `react-dnd` from 9.4.0 to 11.1.3 to fix build error >- switched `ts-loader` to `esbuild-loader` for performance >- switch `webpack-virtual-modules` with `val-loader` to fix build warning (and for easier transition to rspack, since it supports most loader APIs) > >

Reviewers and assignees:

> > > >n/a > > >

Test cases:

> >- Does `@console/internal/file-input` still work as expected? >- Are there any regressions with `formik` or `react-dnd`? >- Do all the Monaco YAML language server features work? >- Does everything else feel the exact same? > >

Additional info:

> > >n/a > > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
spadgett commented 1 week ago

CI is green 🎉

logonoff commented 1 week ago

Thanks, @logonoff. Fantastic work.

Do we know if there are any downstream impacts to plugins with this change? Would be good to have @vojtechszocs review at least the plugin related bits.

From some preliminary testing I couldn't find anything: monitoring-plugin seems to be working fine, including the promql input and charts

logonoff commented 11 hours ago

adding labels as this is tech debt

/label px-approved /label docs-approved

openshift-ci[bot] commented 6 hours ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).