search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

CONSOLE-4125,CONSOLE-4294: Replace SelectDeprecated component in user preferences PerspectiveDropdown #14391

Closed TheRealJon closed 2 weeks ago

TheRealJon commented 1 month ago
openshift-ci-robot commented 1 month ago

@TheRealJon: This pull request references CONSOLE-4125 which is a valid jira issue.

This pull request references CONSOLE-4294 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14391): >- Rename PerspectiveDropdown to PreferredPerspectiveSelect >- Refactor PreferredPerspectiveSelect to use supported PF Select component >- Update unit tests to use RTL Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
TheRealJon commented 1 month ago

QE Approver /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @reestr

rhamilto commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [TheRealJon,rhamilto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanpzhan commented 1 month ago

Launched cluster against the pr. Regression test to Perspective Dropdown field on user preference page passed. /label qe-approved

openshift-ci-robot commented 1 month ago

@TheRealJon: This pull request references CONSOLE-4125 which is a valid jira issue.

This pull request references CONSOLE-4294 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14391): >- Rename PerspectiveDropdown to PreferredPerspectiveSelect >- Refactor PreferredPerspectiveSelect to use supported PF Select component >- Update unit tests to use RTL Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 1 month ago

/retest

TheRealJon commented 1 month ago

@opayne1 @reestr Anything needed from me to move this forward?

TheRealJon commented 3 weeks ago

@opayne1 @reestr PTAL, thanks.

TheRealJon commented 3 weeks ago

@opayne1 Perspective switcher is still the correct terminology. This PR effects a different interaction than the main perspective switcher.

TheRealJon commented 2 weeks ago

@reestr Anything I can do to help expedite? I think this is ready to merge once you approve.

reestr commented 2 weeks ago

/label px-approved

openshift-ci[bot] commented 2 weeks ago

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411111538.p0.g8eba125.assembly.stream.el9. All builds following this will include this PR.