openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-41358: While upgrading the cluster from UI observed `Warning alert:Admission Webhook Warning` #14395

Closed cyril-ui-developer closed 1 month ago

cyril-ui-developer commented 1 month ago

Comparing ClusterVersion responses

Cluster version 4.16

Screenshot 2024-10-15 at 11 18 34 AM

Root cause: The 4.16 cluster version response includes cv?.status?.availableUpdates.channels and cv?.status?.availableUpdates.url which is causing the issue.

Fix The incorrect properties in the cluster cluster version request payload are removed before invoking the update cluster action.

Cluster version 4.18 This issue is not happening in 4.18. It seems the change in the API was not backported to 4.16

Screenshot 2024-10-15 at 11 17 14 AM
openshift-ci-robot commented 1 month ago

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-41358, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14395): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cyril-ui-developer commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-41358, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
In response to [this](https://github.com/openshift/console/pull/14395#issuecomment-2408053288): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-41358, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14395): > >### Comparing ClusterVersion responses > >**Cluster version 4.16** >Screenshot 2024-10-15 at 11 17 14 AM > >**Cluster version 4.18 >Screenshot 2024-10-15 at 11 18 34 AM >** Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cyril-ui-developer commented 1 month ago

/retest

rhamilto commented 1 month ago

/lgtm cancel

rhamilto commented 1 month ago

/lgtm

per @wking's confirmation it's ok to pass both image and version.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [cyril-ui-developer,rhamilto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@cyril-ui-developer: Jira Issue OCPBUGS-41358: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41358 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14395): >### Comparing ClusterVersion responses > >**Cluster version 4.16** >Screenshot 2024-10-15 at 11 18 34 AM > >**Root cause:** >The 4.16 cluster version response includes `cv?.status?.availableUpdates.channels` and `cv?.status?.availableUpdates.url` which is causing the issue. > >**Fix** >The incorrect properties in the cluster cluster version request payload are removed before invoking the update cluster action. > > >**Cluster version 4.18** >This issue is not happening in 4.18. It seems the change in the API was not backported to 4.16 >Screenshot 2024-10-15 at 11 17 14 AM Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 4 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410240140.p0.g18dadc0.assembly.stream.el9. All builds following this will include this PR.

cyril-ui-developer commented 4 weeks ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 4 weeks ago

@cyril-ui-developer: new pull request created: #14433

In response to [this](https://github.com/openshift/console/pull/14395#issuecomment-2435256176): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.