search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-42796: Do not pass CSV name to operand list page when an exen… #14396

Closed TheRealJon closed 1 month ago

TheRealJon commented 1 month ago

…sion is provided.

This was causing some operand list page extensions to fail where props were spread into a ListPage component. The 'name' prop causes the list to be filtered by the CSV name, which will almost always make it empty.

openshift-ci-robot commented 1 month ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-42796, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14396): >…sion is provided. > >This was causing some operand list page extensions to fail where props were spread into a ListPage component. The 'name' prop causes the list to be filtered by the CSV name, which will almost always make it empty. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
TheRealJon commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-42796, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14396#issuecomment-2411999006): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/operator-lifecycle-manager/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/OWNERS)~~ [TheRealJon,rhamilto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@TheRealJon: Jira Issue OCPBUGS-42796: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42796 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14396): >…sion is provided. > >This was causing some operand list page extensions to fail where props were spread into a ListPage component. The 'name' prop causes the list to be filtered by the CSV name, which will almost always make it empty. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.