openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-43360: Start last run do not work in buildConfig details page #14407

Closed lokanandaprabhu closed 1 week ago

lokanandaprabhu commented 1 month ago

Fixes: https://issues.redhat.com/browse/OCPBUGS-43360

Analysis / Root cause: The check was present to see buildConfig.latestBuild is present or not, if not this option should be hidden but by mistake double negation was added

Solution Description: Replaced double negation with single so that if buildConfig.latestBuild is not present then Start last run option will be disabled

Screen shots / Gifs for design review:

----BEFORE---

https://github.com/user-attachments/assets/d5ac2a86-1d7a-4407-89e0-70feee9c966b

---AFTER----

Screenshot 2024-10-17 at 12 35 00 PM

Unit test coverage report: NA

Test setup:

1. Create workloads with with builds 
2. Goto the builds page from navigation 
3. Select the build config 
4. Select the` Start last run` option from the Action menu

Browser conformance:

openshift-ci-robot commented 1 month ago

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-43360, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14407): >**Fixes**: >https://issues.redhat.com/browse/OCPBUGS-43360 > >**Analysis / Root cause**: >The check was present to see `buildConfig.latestBuild` is present or not, if not this option should be hidden but by mistake double negation was added > >**Solution Description**: >Replaced double negation with single so that if `buildConfig.latestBuild` is not present then Start last run option will be disabled > >**Screen shots / Gifs for design review**: > >----BEFORE--- > > >https://github.com/user-attachments/assets/d5ac2a86-1d7a-4407-89e0-70feee9c966b > > > > > > >---AFTER---- > >Screenshot 2024-10-17 at 12 35 00 PM > > > > > > > > > > >**Unit test coverage report**: >NA > >**Test setup:** > > 1. Create workloads with with builds > 2. Goto the builds page from navigation > 3. Select the build config > 4. Select the` Start last run` option from the Action menu > > >**Browser conformance**: > >- [x] Chrome >- [ ] Firefox >- [ ] Safari >- [ ] Edge > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lokanandaprabhu commented 1 month ago

/cc @vikram-raj

lokanandaprabhu commented 2 weeks ago

Updated the PR and handled start last run in both BC list and details page.

https://github.com/user-attachments/assets/f92437ae-c9be-4334-aec4-63cfa646096a

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, lokanandaprabhu, Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 8eba12529f6224e1ac705f8a77a5799cf36edc34 and 2 for PR HEAD 08050805b4b80a1b8b81b0559cfb4aa74d770059 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 3a115ff37f121c8a03679e9dc5303785ab1f6b9b and 2 for PR HEAD 08050805b4b80a1b8b81b0559cfb4aa74d770059 in total

lokanandaprabhu commented 1 week ago

/retest

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 4df2ddc4aa941a2916279983fdc27b0a29b64268 and 2 for PR HEAD 08050805b4b80a1b8b81b0559cfb4aa74d770059 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 4df2ddc4aa941a2916279983fdc27b0a29b64268 and 2 for PR HEAD 08050805b4b80a1b8b81b0559cfb4aa74d770059 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 701dcf11eea9782e0ef634d5cef713762f0054f8 and 2 for PR HEAD 08050805b4b80a1b8b81b0559cfb4aa74d770059 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 78307daa1df9e933da06830a2fd563fe83a9f0f5 and 2 for PR HEAD 08050805b4b80a1b8b81b0559cfb4aa74d770059 in total

openshift-ci[bot] commented 1 week ago

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@lokanandaprabhu: Jira Issue OCPBUGS-43360: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43360 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14407): >**Fixes**: >https://issues.redhat.com/browse/OCPBUGS-43360 > >**Analysis / Root cause**: >The check was present to see `buildConfig.latestBuild` is present or not, if not this option should be hidden but by mistake double negation was added > >**Solution Description**: >Replaced double negation with single so that if `buildConfig.latestBuild` is not present then Start last run option will be disabled > >**Screen shots / Gifs for design review**: > >----BEFORE--- > > >https://github.com/user-attachments/assets/d5ac2a86-1d7a-4407-89e0-70feee9c966b > > > > > > >---AFTER---- > >Screenshot 2024-10-17 at 12 35 00 PM > > > > > > > > > > >**Unit test coverage report**: >NA > >**Test setup:** > > 1. Create workloads with with builds > 2. Goto the builds page from navigation > 3. Select the build config > 4. Select the` Start last run` option from the Action menu > > >**Browser conformance**: > >- [x] Chrome >- [ ] Firefox >- [ ] Safari >- [ ] Edge > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411131208.p0.gd60f090.assembly.stream.el9. All builds following this will include this PR.

lokanandaprabhu commented 1 week ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 1 week ago

@lokanandaprabhu: new pull request created: #14499

In response to [this](https://github.com/openshift/console/pull/14407#issuecomment-2477932189): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.