openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-43409: 'control plane' option is missing on 'filter node type' list #14412

Closed Mylanos closed 1 month ago

Mylanos commented 1 month ago

Analysis: The name metadata adjusted to not use the word 'master' for the MachineConfigPool was not passed as a children to the SelectOption

Resolution: Pass the adjusted value Before: Screenshot 2024-10-17 at 14 17 08

After: Screenshot 2024-10-17 at 14 16 23 Screenshot 2024-10-17 at 14 16 27

openshift-ci-robot commented 1 month ago

@Mylanos: This pull request references Jira Issue OCPBUGS-43409, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14412): >Analysis: The name metadata adjusted to not use the word 'master' for the MachineConfigPool was not passed as a children to the SelectOption > >Resolution: Pass the adjusted value >Before: >![Screenshot 2024-10-17 at 14 17 08](https://github.com/user-attachments/assets/ae45ce01-55b3-4318-af73-453b12812ff2) > >After: >![Screenshot 2024-10-17 at 14 16 23](https://github.com/user-attachments/assets/1972ee94-6680-4785-b421-0d78fc5c80ae) >![Screenshot 2024-10-17 at 14 16 27](https://github.com/user-attachments/assets/92cdc3fa-22d1-4d49-adc0-3734fb63b323) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Mylanos commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@Mylanos: This pull request references Jira Issue OCPBUGS-43409, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14412#issuecomment-2419415592): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jhadvig commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/public/components/dashboard/OWNERS](https://github.com/openshift/console/blob/master/frontend/public/components/dashboard/OWNERS)~~ [jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 96b52fe415d939c675b1fd62dbcc4ce6fe04dbd9 and 2 for PR HEAD ae0700c54c650a6756cd83e184bb3a55f97b5b03 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 5c61f4ed3bf4944a5024a5075cd05a9baae97201 and 2 for PR HEAD ae0700c54c650a6756cd83e184bb3a55f97b5b03 in total

openshift-ci[bot] commented 1 month ago

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@Mylanos: Jira Issue OCPBUGS-43409: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43409 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14412): >Analysis: The name metadata adjusted to not use the word 'master' for the MachineConfigPool was not passed as a children to the SelectOption > >Resolution: Pass the adjusted value >Before: >![Screenshot 2024-10-17 at 14 17 08](https://github.com/user-attachments/assets/ae45ce01-55b3-4318-af73-453b12812ff2) > >After: >![Screenshot 2024-10-17 at 14 16 23](https://github.com/user-attachments/assets/1972ee94-6680-4785-b421-0d78fc5c80ae) >![Screenshot 2024-10-17 at 14 16 27](https://github.com/user-attachments/assets/92cdc3fa-22d1-4d49-adc0-3734fb63b323) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410221510.p0.g061a58c.assembly.stream.el9. All builds following this will include this PR.