search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-23924: Render TaskRun results even when failed #14414

Open logonoff opened 1 month ago

logonoff commented 1 month ago

Fixes:

OCPBUGS-23924

Analysis / Root cause:

Render of TaskRun results was blocked if failed

Solution Description:

Render results regardless of failure

Screen shots / Gifs for design review:

https://github.com/user-attachments/assets/a21c12c3-767c-43a4-8f3d-afb21b776677

Unit test coverage report:

n/a

Test setup:

install pipeline operator and use the pipeline provided in the jira

Browser conformance:

openshift-ci-robot commented 1 month ago

@logonoff: This pull request references Jira Issue OCPBUGS-23924, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14414): >**Fixes**: > >[OCPBUGS-23924](https://issues.redhat.com/browse/OCPBUGS-23924) > >**Analysis / Root cause**: > >Render of `TaskRun` results was blocked if failed > >**Solution Description**: > >Render results regardless of failure > >**Screen shots / Gifs for design review**: > > >https://github.com/user-attachments/assets/a21c12c3-767c-43a4-8f3d-afb21b776677 > >**Unit test coverage report**: > >n/a > >**Test setup:** > >install pipeline operator and use the pipeline provided in the jira > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@logonoff: This pull request references Jira Issue OCPBUGS-23924, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14414#issuecomment-2420221903): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 month ago

code review: /assign @lokanandaprabhu

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff Once this PR has been reviewed and has the lgtm label, please ask for approval from lokanandaprabhu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/packages/pipelines-plugin/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/pipelines-plugin/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).