openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-43652: Filter dropdown doesn't collapse on second click #14427

Closed Mylanos closed 1 month ago

Mylanos commented 1 month ago

The select dropdown didnt close on the second click.

The MenuToggle used only the previous value to set the state variable isOpen that determines if the dropdown is opened or not. Using and negating the previous value fixes this problem.

After:

https://github.com/user-attachments/assets/19d829df-f127-4780-b7e1-d15ac887019e

openshift-ci-robot commented 1 month ago

@Mylanos: This pull request references Jira Issue OCPBUGS-43652, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14427): >The select dropdown didnt close on the second click. > >The MenuToggle used only the previous value to set the state variable isOpen that determines if the dropdown is opened or not. Using and negating the previous value fixes this problem. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Mylanos commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@Mylanos: This pull request references Jira Issue OCPBUGS-43652, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14427#issuecomment-2429508437): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@Mylanos: This pull request references Jira Issue OCPBUGS-43652, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14427): >The select dropdown didnt close on the second click. > >The MenuToggle used only the previous value to set the state variable isOpen that determines if the dropdown is opened or not. Using and negating the previous value fixes this problem. > >After: >https://github.com/user-attachments/assets/19d829df-f127-4780-b7e1-d15ac887019e > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 6577e738d06b7a9b2275e5f109e79e668f200229 and 2 for PR HEAD f94a6a18976403ad2793475052cd60af9185a3fc in total

openshift-ci[bot] commented 1 month ago

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@Mylanos: Jira Issue OCPBUGS-43652: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43652 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14427): >The select dropdown didnt close on the second click. > >The MenuToggle used only the previous value to set the state variable isOpen that determines if the dropdown is opened or not. Using and negating the previous value fixes this problem. > >After: > >https://github.com/user-attachments/assets/19d829df-f127-4780-b7e1-d15ac887019e > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410232040.p0.gb7fbfc3.assembly.stream.el9. All builds following this will include this PR.