search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

CONSOLE-4234,CONSOLE-4298,CONSOLE-4299: Remove PF deprecated table from public/components/factory/table.tsx and public/components/factory/Table/VirtualizedTable.tsx #14436

Open TheRealJon opened 1 month ago

TheRealJon commented 1 month ago

public/components/factory/table.tsx

public/components/factory/Table/VirtualizedTable.tsx

openshift-ci-robot commented 1 month ago

@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4298 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14436): >- Refactor public/components/factory/table.tsx to remove deprecated PF table >- Separate virtualized/non-virtualized tables into local sub-components >- Remove unused generic types Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
TheRealJon commented 1 month ago

QE Approver /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @reestr

yanpzhan commented 1 month ago

Regression test about table against the pr code passed. /label qe-approved

openshift-ci-robot commented 1 month ago

@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4298 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14436): >- Refactor public/components/factory/table.tsx to remove deprecated PF table >- Separate virtualized/non-virtualized tables into local sub-components >- Remove unused generic types Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4298 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4299 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14436): >- Refactor public/components/factory/table.tsx to remove deprecated PF table >- Separate virtualized/non-virtualized tables into local sub-components >- Remove unused generic types Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4298 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4299 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14436): >public/components/factory/table.tsx >- Refactor Table component to remove PatternFly deprecated Table component >- Separate virtualized/non-virtualized tables into local sub-components >- Remove unused generic types > >public/components/factory/Table/VirtualizedTable.tsx >- Refactor VirtualizedTable component to remove PatternFly deprecated Table component Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@TheRealJon: This pull request references CONSOLE-4234 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4298 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4299 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14436): >public/components/factory/table.tsx >- Refactor Table component to remove PatternFly deprecated Table component >- Separate virtualized/non-virtualized tables into local sub-components >- Remove unused generic types >- Address some nits and tech debt > >public/components/factory/Table/VirtualizedTable.tsx >- Refactor VirtualizedTable component to remove PatternFly deprecated Table component >- Address a few nits and tech debt Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
opayne1 commented 3 weeks ago

/label docs-approved

TheRealJon commented 2 weeks ago

/retest

reestr commented 2 weeks ago

/label px-approved

TheRealJon commented 2 weeks ago

/retest

TheRealJon commented 1 week ago

/retest

TheRealJon commented 1 week ago

/retest

rhamilto commented 4 days ago

/label acknowledge-critical-fixes-only

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD ea76ee699113d251e74be989e6ca9613e717db33 and 2 for PR HEAD eebeb8ecc316b0c36073430084711a2095e7f5b1 in total

jhadvig commented 4 days ago

/retest

jhadvig commented 3 days ago

/retest

openshift-ci-robot commented 3 days ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 1 for PR HEAD eebeb8ecc316b0c36073430084711a2095e7f5b1 in total

openshift-ci-robot commented 3 days ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD eebeb8ecc316b0c36073430084711a2095e7f5b1 in total

openshift-ci-robot commented 3 days ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD eebeb8ecc316b0c36073430084711a2095e7f5b1 in total

rhamilto commented 3 days ago

/lgtm

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [TheRealJon,rhamilto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 days ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD a9fa2ed6ca63ad1ab022e40246074a0f951d6137 in total

openshift-ci[bot] commented 3 days ago

New changes are detected. LGTM label has been removed.

rhamilto commented 19 hours ago

/retest

openshift-ci[bot] commented 16 hours ago

@TheRealJon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 461fdded38851c570422da62976945f74bf3ad17 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).