Closed logonoff closed 3 weeks ago
@logonoff: This pull request references Jira Issue OCPBUGS-43853, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @sanketpathak
The bug has been updated to refer to the pull request using the external bug tracker.
/cc @zhuje /cc @TheRealJon
Are these okay to remove?
@logonoff: all tests passed!
Full PR test history. Your PR dashboard.
@logonoff: This pull request references Jira Issue OCPBUGS-43853, which is valid.
Requesting review from QA contact: /cc @sanketpathak
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, TheRealJon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@logonoff: Jira Issue OCPBUGS-43853: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-43853 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410302041.p0.g5e8c422.assembly.stream.el9. All builds following this will include this PR.
Fixes:
https://issues.redhat.com//browse/OCPBUGS-43853
Analysis / Root cause:
In CONSOLE-4187, the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary
Meanwhile in https://github.com/openshift/console/commit/092e20044109d764a65fb0d757405faacd33fc7b,
plotly.js
was removed, which removes the need forglslify-loader
.Solution Description:
Remove those files
Screen shots / Gifs for design review:
n/a
Unit test coverage report:
n/a
Test setup:
Nothing should have changed testing-wise. Everything should work the same as previously
Browser conformance: