openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-43853: Remove promql-expression-input and table-pagination #14442

Closed logonoff closed 3 weeks ago

logonoff commented 3 weeks ago

Fixes:

https://issues.redhat.com//browse/OCPBUGS-43853

Analysis / Root cause:

In CONSOLE-4187, the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary

Meanwhile in https://github.com/openshift/console/commit/092e20044109d764a65fb0d757405faacd33fc7b, plotly.js was removed, which removes the need for glslify-loader.

Solution Description:

Remove those files

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Nothing should have changed testing-wise. Everything should work the same as previously

Browser conformance:

openshift-ci-robot commented 3 weeks ago

@logonoff: This pull request references Jira Issue OCPBUGS-43853, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14442): >**Fixes**: > >https://issues.redhat.com//browse/OCPBUGS-43853 > >**Analysis / Root cause**: > >In [CONSOLE-4187](https://issues.redhat.com/browse/CONSOLE-4187), the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary > >**Solution Description**: > >Remove those files > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Nothing should have changed testing-wise. Everything should work the same as previously > >**Browser conformance**: > >- [] Chrome >- [ ] Firefox >- [ ] Safari Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 3 weeks ago

/cc @zhuje /cc @TheRealJon

Are these okay to remove?

openshift-ci[bot] commented 3 weeks ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 weeks ago

@logonoff: This pull request references Jira Issue OCPBUGS-43853, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14442): >**Fixes**: > >https://issues.redhat.com//browse/OCPBUGS-43853 > >**Analysis / Root cause**: > >In [CONSOLE-4187](https://issues.redhat.com/browse/CONSOLE-4187), the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary > >Meanwhile in https://github.com/openshift/console/commit/092e20044109d764a65fb0d757405faacd33fc7b, `plotly.js` was removed, which removes the need for `glslify-loader`. > >**Solution Description**: > >Remove those files > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Nothing should have changed testing-wise. Everything should work the same as previously > >**Browser conformance**: > >- [] Chrome >- [ ] Firefox >- [ ] Safari Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
TheRealJon commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [TheRealJon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

@logonoff: Jira Issue OCPBUGS-43853: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43853 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14442): >**Fixes**: > >https://issues.redhat.com//browse/OCPBUGS-43853 > >**Analysis / Root cause**: > >In [CONSOLE-4187](https://issues.redhat.com/browse/CONSOLE-4187), the metrics page was removed from the console, but some related packages (i.e., the codemirror ones) remained, even though they are now unnecessary > >Meanwhile in https://github.com/openshift/console/commit/092e20044109d764a65fb0d757405faacd33fc7b, `plotly.js` was removed, which removes the need for `glslify-loader`. > >**Solution Description**: > >Remove those files > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Nothing should have changed testing-wise. Everything should work the same as previously > >**Browser conformance**: > >- [] Chrome >- [ ] Firefox >- [ ] Safari Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202410302041.p0.g5e8c422.assembly.stream.el9. All builds following this will include this PR.