Closed upalatucci closed 3 weeks ago
@upalatucci: This pull request references CNV-43052 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.
@upalatucci: This pull request references CNV-43052 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.
/retest
/retest
@upalatucci: This pull request references Jira Issue OCPBUGS-43998, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @sanketpathak
The bug has been updated to refer to the pull request using the external bug tracker.
@upalatucci: This pull request references Jira Issue OCPBUGS-43998, which is valid.
Requesting review from QA contact: /cc @sanketpathak
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: TheRealJon, upalatucci
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD ee79097a3e971fe5dd1d1da7692e31ec52d228c5 and 2 for PR HEAD bd1ef6c2aff4379c7026b37e56999b776ae436ca in total
@upalatucci: all tests passed!
Full PR test history. Your PR dashboard.
@upalatucci: Jira Issue OCPBUGS-43998: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-43998 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411010608.p0.g8c56f50.assembly.stream.el9. All builds following this will include this PR.
Lets just use a patternfly feature in the virtualized table. We already have the onSelect method for doing that but it's pretty much useless if we don't add those two props for controlling the header select.
Demo
List state when we use the
onSelect
prop (You can't check the header checkbox)Have selection in the table but not in the header
Select the header selection in case all rows are selected