openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-43998: add allRowsSelected and canSelectAll in the virtualizedtable #14447

Closed upalatucci closed 3 weeks ago

upalatucci commented 3 weeks ago

Lets just use a patternfly feature in the virtualized table. We already have the onSelect method for doing that but it's pretty much useless if we don't add those two props for controlling the header select.

Demo

List state when we use the onSelect prop (You can't check the header checkbox)

Screenshot 2024-10-30 at 10 56 25

Have selection in the table but not in the header

Screenshot 2024-10-29 at 16 22 27

Select the header selection in case all rows are selected

Screenshot 2024-10-29 at 16 21 44
openshift-ci-robot commented 3 weeks ago

@upalatucci: This pull request references CNV-43052 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14447): > > >Lets just use a patternfly feature in the virtualized table. We already have the onSelect method for doing that but it's pretty much useless if we don't add those two props for controlling the header select. > > > >**Demo** > >**Have selection in the table but not in the header** >Screenshot 2024-10-29 at 16 22 27 > > >**Select the header selection in case all rows are selected** > >Screenshot 2024-10-29 at 16 21 44 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@upalatucci: This pull request references CNV-43052 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14447): > >Lets just use a patternfly feature in the virtualized table. We already have the onSelect method for doing that but it's pretty much useless if we don't add those two props for controlling the header select. > > > >**Demo** > >**List state when we use the `onSelect` prop** >(You can't check the header checkbox) > >Screenshot 2024-10-29 at 16 32 02 > > > > >**Have selection in the table but not in the header** >Screenshot 2024-10-29 at 16 22 27 > > >**Select the header selection in case all rows are selected** > >Screenshot 2024-10-29 at 16 21 44 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
upalatucci commented 3 weeks ago

/retest

upalatucci commented 3 weeks ago

/retest

openshift-ci-robot commented 3 weeks ago

@upalatucci: This pull request references Jira Issue OCPBUGS-43998, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14447): > >Lets just use a patternfly feature in the virtualized table. We already have the onSelect method for doing that but it's pretty much useless if we don't add those two props for controlling the header select. > > > >**Demo** > >**List state when we use the `onSelect` prop** >(You can't check the header checkbox) > >Screenshot 2024-10-29 at 16 32 02 > > > > >**Have selection in the table but not in the header** >Screenshot 2024-10-29 at 16 22 27 > > >**Select the header selection in case all rows are selected** > >Screenshot 2024-10-29 at 16 21 44 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@upalatucci: This pull request references Jira Issue OCPBUGS-43998, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14447): >Lets just use a patternfly feature in the virtualized table. We already have the onSelect method for doing that but it's pretty much useless if we don't add those two props for controlling the header select. > > > >**Demo** > >**List state when we use the `onSelect` prop** >(You can't check the header checkbox) > >Screenshot 2024-10-30 at 10 56 25 > > >**Have selection in the table but not in the header** >Screenshot 2024-10-29 at 16 22 27 > > >**Select the header selection in case all rows are selected** > >Screenshot 2024-10-29 at 16 21 44 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [TheRealJon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD ee79097a3e971fe5dd1d1da7692e31ec52d228c5 and 2 for PR HEAD bd1ef6c2aff4379c7026b37e56999b776ae436ca in total

openshift-ci[bot] commented 3 weeks ago

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 weeks ago

@upalatucci: Jira Issue OCPBUGS-43998: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43998 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14447): >Lets just use a patternfly feature in the virtualized table. We already have the onSelect method for doing that but it's pretty much useless if we don't add those two props for controlling the header select. > > > >**Demo** > >**List state when we use the `onSelect` prop** >(You can't check the header checkbox) > >Screenshot 2024-10-30 at 10 56 25 > > >**Have selection in the table but not in the header** >Screenshot 2024-10-29 at 16 22 27 > > >**Select the header selection in case all rows are selected** > >Screenshot 2024-10-29 at 16 21 44 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411010608.p0.g8c56f50.assembly.stream.el9. All builds following this will include this PR.