openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-43830: Expand "Rollback Helm Release" status width #14448

Open logonoff opened 3 weeks ago

logonoff commented 3 weeks ago

Fixes:

https://issues.redhat.com/browse/OCPBUGS-43830

Analysis / Root cause:

Status text was too long for the width so it overlapped with the content in the next column

Solution Description:

Expand width of status header

Screen shots / Gifs for design review:

Before: Screenshot From 2024-11-20 10-16-38

After: Screenshot From 2024-11-20 10-16-34

Unit test coverage report:

n/a

Test setup:

Create a helm release, then upgrade it, then go to "Rollback Helm Release"

Browser conformance:

openshift-ci-robot commented 3 weeks ago

@logonoff: This pull request references Jira Issue OCPBUGS-43830, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14448): >**Fixes**: > >https://issues.redhat.com/browse/OCPBUGS-43830 > >**Analysis / Root cause**: > >Status text was not truncated so it overlapped with the content in the next column > >**Solution Description**: > >Truncate the text > >**Screen shots / Gifs for design review**: > >Before: >![Uploading image.png…]() > > >After: >![image](https://github.com/user-attachments/assets/f11e6a4c-26b6-4b35-be90-eabea50c898e) > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Create a helm release, then upgrade it, then go to "Rollback Helm Release" > >**Browser conformance**: > >- [ ] Chrome >- [x] Firefox >- [ ] Safari Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@logonoff: This pull request references Jira Issue OCPBUGS-43830, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14448#issuecomment-2445151489): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 5 days ago

@logonoff: This pull request references Jira Issue OCPBUGS-43830, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14448): >**Fixes**: > >https://issues.redhat.com/browse/OCPBUGS-43830 > >**Analysis / Root cause**: > >Status text was not truncated so it overlapped with the content in the next column > >**Solution Description**: > >Truncate the text > >**Screen shots / Gifs for design review**: > > >Before: >![Screenshot From 2024-11-20 10-16-38](https://github.com/user-attachments/assets/5189978b-1fbf-4c0e-b657-768b676201be) > >After: >![Screenshot From 2024-11-20 10-16-38](https://github.com/user-attachments/assets/7a4c7051-d356-42ad-9da3-2a16cd6b0069) > > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Create a helm release, then upgrade it, then go to "Rollback Helm Release" > >**Browser conformance**: > >- [x] Chrome >- [x] Firefox >- [ ] Safari Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 5 days ago

/retest

logonoff commented 5 days ago

/label acknowledge-critical-fixes-only

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/helm-plugin/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/helm-plugin/OWNERS)~~ [lokanandaprabhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 days ago

/retest-required

Remaining retests: 0 against base HEAD ea76ee699113d251e74be989e6ca9613e717db33 and 2 for PR HEAD 71485c9e9469e30e470f6856a63f8a1856ebfcc8 in total

logonoff commented 3 days ago

/retest

logonoff commented 3 days ago

/retest

openshift-ci-robot commented 3 days ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD 71485c9e9469e30e470f6856a63f8a1856ebfcc8 in total

logonoff commented 3 days ago

/retest

openshift-ci-robot commented 1 day ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD 71485c9e9469e30e470f6856a63f8a1856ebfcc8 in total

openshift-ci-robot commented 21 hours ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD 71485c9e9469e30e470f6856a63f8a1856ebfcc8 in total

openshift-ci-robot commented 16 hours ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD 71485c9e9469e30e470f6856a63f8a1856ebfcc8 in total

openshift-ci-robot commented 13 hours ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD 71485c9e9469e30e470f6856a63f8a1856ebfcc8 in total

openshift-ci-robot commented 9 hours ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 2 for PR HEAD 71485c9e9469e30e470f6856a63f8a1856ebfcc8 in total

openshift-ci[bot] commented 5 hours ago

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 71485c9e9469e30e470f6856a63f8a1856ebfcc8 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).