search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-43983: update ConditionalUpdates release type #14452

Closed yapei closed 1 week ago

yapei commented 3 weeks ago

After: ConditonalUpdate patch will look like following, which will not trigger Admission Webhook Warning

[{"op":"add","path":"/spec/desiredUpdate","value":{"image":"registry.ci.openshift.org/ocp/release@sha256:20abbd29314c68c67cd6822952f5688bc5955d526b5663e561780d2cffa4277a","version":"4.18.0-0.nightly-2024-10-31-064113"}}]

https://github.com/user-attachments/assets/f19e5cc6-c03e-4513-b217-256ec1e98eb7

openshift-ci-robot commented 3 weeks ago

@yapei: This pull request references Jira Issue OCPBUGS-43983, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14452): >After: ConditonalUpdate patch will look like following, which will not trigger Admission Webhook Warning >``` >[{"op":"add","path":"/spec/desiredUpdate","value":{"image":"registry.ci.openshift.org/ocp/release@sha256:20abbd29314c68c67cd6822952f5688bc5955d526b5663e561780d2cffa4277a","version":"4.18.0-0.nightly-2024-10-31-064113"}}] >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yapei commented 3 weeks ago

@cyril-ui-developer Could you help review?

openshift-ci-robot commented 2 weeks ago

@yapei: This pull request references Jira Issue OCPBUGS-43983, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14452): >After: ConditonalUpdate patch will look like following, which will not trigger Admission Webhook Warning >``` >[{"op":"add","path":"/spec/desiredUpdate","value":{"image":"registry.ci.openshift.org/ocp/release@sha256:20abbd29314c68c67cd6822952f5688bc5955d526b5663e561780d2cffa4277a","version":"4.18.0-0.nightly-2024-10-31-064113"}}] >``` >https://github.com/user-attachments/assets/f19e5cc6-c03e-4513-b217-256ec1e98eb7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yapei.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/console/pull/14452#issuecomment-2456907181): >@yapei: This pull request references [Jira Issue OCPBUGS-43983](https://issues.redhat.com//browse/OCPBUGS-43983), which is valid. The bug has been moved to the POST state. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.18.0) matches configured target version for branch (4.18.0) >* bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14452): >After: ConditonalUpdate patch will look like following, which will not trigger Admission Webhook Warning >``` >[{"op":"add","path":"/spec/desiredUpdate","value":{"image":"registry.ci.openshift.org/ocp/release@sha256:20abbd29314c68c67cd6822952f5688bc5955d526b5663e561780d2cffa4277a","version":"4.18.0-0.nightly-2024-10-31-064113"}}] >``` >https://github.com/user-attachments/assets/f19e5cc6-c03e-4513-b217-256ec1e98eb7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yapei commented 2 weeks ago

@cyril-ui-developer updated according to the comments, PTAL, thanks!

yapei commented 2 weeks ago

/hold

yapei commented 1 week ago

This is the PATCH request payload we are sending

Screenshot 2024-11-13 at 10 13 23 PM

and here is the warning message we are seeing on console

ClusterVersion version violates policy 299 - "unknown field \"spec.desiredUpdate.channels\""
cyril-ui-developer commented 1 week ago

This is the PATCH request payload we are sending Screenshot 2024-11-13 at 10 13 23 PM

and here is the warning message we are seeing on console

ClusterVersion version violates policy 299 - "unknown field \"spec.desiredUpdate.channels\""

@wking If the urland channels fields are marked as +optional and omitempty, why is the API server triggering a warning response for them? Any idea why this is happening?

cyril-ui-developer commented 1 week ago

/lgtm @yapei Thank you for this contribution.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [cyril-ui-developer] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yapei commented 1 week ago

/unhold

openshift-ci[bot] commented 1 week ago

@yapei: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@yapei: Jira Issue OCPBUGS-43983: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43983 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14452): >After: ConditonalUpdate patch will look like following, which will not trigger Admission Webhook Warning >``` >[{"op":"add","path":"/spec/desiredUpdate","value":{"image":"registry.ci.openshift.org/ocp/release@sha256:20abbd29314c68c67cd6822952f5688bc5955d526b5663e561780d2cffa4277a","version":"4.18.0-0.nightly-2024-10-31-064113"}}] >``` >https://github.com/user-attachments/assets/f19e5cc6-c03e-4513-b217-256ec1e98eb7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.19.0-202411161407.p0.g048685c.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411161407.p0.g048685c.assembly.stream.el9. All builds following this will include this PR.

cyril-ui-developer commented 1 week ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 1 week ago

@cyril-ui-developer: new pull request created: #14505

In response to [this](https://github.com/openshift/console/pull/14452#issuecomment-2483093540): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.