Open Mylanos opened 3 weeks ago
@Mylanos: This pull request references CONSOLE-4075 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
TODO: Been looking into the ways we use crypto libraries and saw that there is one single instance where we use crypto-browserify
package to generate new hashes. We should probably replace it with Crypto as back then this library was most likely not present so we opted for crypto-browserify.
/retest
Following up on our discussions, I have removed the fallback/our own UUID generator function as the window.randomUUID()
works fine and it should be available on all of the browsers we currently support.
@Mylanos: This pull request references CONSOLE-4075 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
After the update that incorporated PF components.
https://github.com/user-attachments/assets/1bf641dc-fc33-44c1-a890-059f846ff391
/retest
/retest
/retest
@Mylanos: This pull request references CONSOLE-4075 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
/hold
@logonoff So I discussed with Jon about the extent of the refactors in these components, and he said that the scope of the story was just a logical refactor ( class component to functional ) and the PatternFly updates were out of scope just because these were already big stories.
We decided to keep this stories just as a logical refactor and I have created a separate story where we will update all of the components affected in the secrets form tech debt epic. This will make it easier to consolidate the styling between all of the forms and not affect other PRs that are already in review.
So I'm holding this PR at this moment I will stash the current changes of my PR (that included the PF components update, that will be used later on in the new story) and roll-back to the commit where I have not used the PF components yet.
/lgtm
Adding labels as this is debt /label px-approved /label docs-approved
Sorry @logonoff you might have to add the label again, the latest commit without PF update didn't have the message disclaimer for the @ts-ignore yet, so I added it in new commit.
/unhold
/lgtm
/label tide/merge-method-squash
/retest
/retest
/test okd-scos-e2e-aws-ovn
QE Approver /assign @yapei
no regressions found /label qe-approved
@Mylanos: This pull request references CONSOLE-4075 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
/retest
/retest-required
Remaining retests: 0 against base HEAD cb576e516621bf0dcb6d5276848f03623676e4b7 and 2 for PR HEAD db4e4eae75037011b9c7b8cecc13d7b5af7e5628 in total
/retest-required
Remaining retests: 0 against base HEAD cb576e516621bf0dcb6d5276848f03623676e4b7 and 2 for PR HEAD db4e4eae75037011b9c7b8cecc13d7b5af7e5628 in total
/retest-required
Remaining retests: 0 against base HEAD d92f5f8ed5f206f6d369502182fe03fae505cde5 and 1 for PR HEAD db4e4eae75037011b9c7b8cecc13d7b5af7e5628 in total
/retest-required
Remaining retests: 0 against base HEAD 9d35cf2370f8594e23a7300a906cdea24a6b76ba and 2 for PR HEAD db4e4eae75037011b9c7b8cecc13d7b5af7e5628 in total
@Mylanos: all tests passed!
Full PR test history. Your PR dashboard.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, logonoff, Mylanos
The full list of commands accepted by this bot can be found here.
The pull request process is described here
before:
https://github.com/user-attachments/assets/0e9c87ab-f962-4589-ad16-3439d7a81d5c
after:
https://github.com/user-attachments/assets/3ceb51aa-d2cf-48a5-83c4-5d481de97f5b