openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

CONSOLE-4075: address tech debt in web hook secret form component #14454

Open Mylanos opened 3 weeks ago

Mylanos commented 3 weeks ago

before:

https://github.com/user-attachments/assets/0e9c87ab-f962-4589-ad16-3439d7a81d5c

after:

https://github.com/user-attachments/assets/3ceb51aa-d2cf-48a5-83c4-5d481de97f5b

openshift-ci-robot commented 3 weeks ago

@Mylanos: This pull request references CONSOLE-4075 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14454): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Mylanos commented 3 weeks ago

TODO: Been looking into the ways we use crypto libraries and saw that there is one single instance where we use crypto-browserify package to generate new hashes. We should probably replace it with Crypto as back then this library was most likely not present so we opted for crypto-browserify.

Mylanos commented 2 weeks ago

/retest

Mylanos commented 2 weeks ago

Following up on our discussions, I have removed the fallback/our own UUID generator function as the window.randomUUID() works fine and it should be available on all of the browsers we currently support.

openshift-ci-robot commented 2 weeks ago

@Mylanos: This pull request references CONSOLE-4075 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14454): >after changes: > >https://github.com/user-attachments/assets/0e9c87ab-f962-4589-ad16-3439d7a81d5c > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Mylanos commented 2 weeks ago

After the update that incorporated PF components.

https://github.com/user-attachments/assets/1bf641dc-fc33-44c1-a890-059f846ff391

Mylanos commented 1 week ago

/retest

logonoff commented 1 week ago

/retest

Mylanos commented 1 week ago

/retest

openshift-ci-robot commented 1 week ago

@Mylanos: This pull request references CONSOLE-4075 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14454): >before: > >https://github.com/user-attachments/assets/0e9c87ab-f962-4589-ad16-3439d7a81d5c > >after: > > >https://github.com/user-attachments/assets/3ceb51aa-d2cf-48a5-83c4-5d481de97f5b > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Mylanos commented 1 week ago

/hold

Mylanos commented 1 week ago

@logonoff So I discussed with Jon about the extent of the refactors in these components, and he said that the scope of the story was just a logical refactor ( class component to functional ) and the PatternFly updates were out of scope just because these were already big stories.

We decided to keep this stories just as a logical refactor and I have created a separate story where we will update all of the components affected in the secrets form tech debt epic. This will make it easier to consolidate the styling between all of the forms and not affect other PRs that are already in review.

So I'm holding this PR at this moment I will stash the current changes of my PR (that included the PF components update, that will be used later on in the new story) and roll-back to the commit where I have not used the PF components yet.

logonoff commented 1 week ago

/lgtm

logonoff commented 1 week ago

Adding labels as this is debt /label px-approved /label docs-approved

Mylanos commented 1 week ago

Sorry @logonoff you might have to add the label again, the latest commit without PF update didn't have the message disclaimer for the @ts-ignore yet, so I added it in new commit.

Mylanos commented 1 week ago

/unhold

logonoff commented 1 week ago

/lgtm

logonoff commented 1 week ago

/label tide/merge-method-squash

logonoff commented 1 week ago

/retest

Mylanos commented 1 week ago

/retest

Mylanos commented 1 week ago

/test okd-scos-e2e-aws-ovn

Mylanos commented 1 week ago

QE Approver /assign @yapei

yapei commented 4 days ago

no regressions found /label qe-approved

openshift-ci-robot commented 4 days ago

@Mylanos: This pull request references CONSOLE-4075 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14454): >before: > >https://github.com/user-attachments/assets/0e9c87ab-f962-4589-ad16-3439d7a81d5c > >after: > > >https://github.com/user-attachments/assets/3ceb51aa-d2cf-48a5-83c4-5d481de97f5b > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Mylanos commented 4 days ago

/retest

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD cb576e516621bf0dcb6d5276848f03623676e4b7 and 2 for PR HEAD db4e4eae75037011b9c7b8cecc13d7b5af7e5628 in total

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD cb576e516621bf0dcb6d5276848f03623676e4b7 and 2 for PR HEAD db4e4eae75037011b9c7b8cecc13d7b5af7e5628 in total

openshift-ci-robot commented 3 days ago

/retest-required

Remaining retests: 0 against base HEAD d92f5f8ed5f206f6d369502182fe03fae505cde5 and 1 for PR HEAD db4e4eae75037011b9c7b8cecc13d7b5af7e5628 in total

openshift-ci-robot commented 3 days ago

/retest-required

Remaining retests: 0 against base HEAD 9d35cf2370f8594e23a7300a906cdea24a6b76ba and 2 for PR HEAD db4e4eae75037011b9c7b8cecc13d7b5af7e5628 in total

openshift-ci[bot] commented 3 days ago

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, logonoff, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment