openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-43266: remove Architecture from workloads Metrics tab #14458

Closed yapei closed 2 weeks ago

yapei commented 2 weeks ago

Architecture metrics seems not needed regarding comments Also Architecture metrics only returns No datapoints found

Screenshot 2024-11-04 at 4 43 28 PM
openshift-ci-robot commented 2 weeks ago

@yapei: This pull request references Jira Issue OCPBUGS-43266, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14458): >`Architecture` metrics seems not needed regarding [comments](https://github.com/openshift/console/pull/13718/files#r1550952714) >Also `Architecture` metrics only returns `No datapoints found` > >Screenshot 2024-11-04 at 4 43 28 PM > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yapei commented 2 weeks ago

@rawagner Could you help review this fix? Thanks a lot!

rawagner commented 2 weeks ago

/jira refresh /lgtm

thank you @yapei !

openshift-ci-robot commented 2 weeks ago

@rawagner: This pull request references Jira Issue OCPBUGS-43266, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @XiyunZhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14458#issuecomment-2454555891): >/jira refresh >/lgtm > >thank you @yapei ! Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [rawagner] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD bcd8cbdbc279e3cfd65ad831033292376c8cf2bd and 2 for PR HEAD 6ca05315d96c2e4efd000df2ad58061a1fc0c1cf in total

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 8b71ababad778a5d87dda678b76c0b3bd3c169bf and 1 for PR HEAD 6ca05315d96c2e4efd000df2ad58061a1fc0c1cf in total

openshift-ci[bot] commented 2 weeks ago

@yapei: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 weeks ago

@yapei: Jira Issue OCPBUGS-43266: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43266 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14458): >`Architecture` metrics seems not needed regarding [comments](https://github.com/openshift/console/pull/13718/files#r1550952714) >Also `Architecture` metrics only returns `No datapoints found` > >Screenshot 2024-11-04 at 4 43 28 PM > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411050638.p0.geb90edb.assembly.stream.el9. All builds following this will include this PR.