search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-31367: include external labels so silenced alerts not displayed in notifications #14464

Closed jgbernalp closed 1 week ago

jgbernalp commented 2 weeks ago

This PR adds external labels to Redux alerts to hide silenced alerts from notifications.

https://github.com/user-attachments/assets/449733fd-204e-479a-b219-282ed55832e7

openshift-ci-robot commented 2 weeks ago

@jgbernalp: This pull request references Jira Issue OCPBUGS-31367, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14464): >This PR adds the external labels to the alerts stored in redux to be able to effectively hide them from the notifications when the alert is silenced. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@jgbernalp: This pull request references Jira Issue OCPBUGS-31367, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14464): >This PR adds external labels to Redux alerts to hide silenced alerts from notifications. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jgbernalp commented 2 weeks ago

Docs Approver: /assign @opayne1

PX Approver: /assign @reestr

PeterYurkovich commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/public/components/monitoring/OWNERS](https://github.com/openshift/console/blob/master/frontend/public/components/monitoring/OWNERS)~~ [PeterYurkovich,jgbernalp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
opayne1 commented 2 weeks ago

/label docs-approved

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD eb90edbc440cec97c2bab04ee4e791bc51fba45a and 2 for PR HEAD f3c27b80649cb1f2b94c22ba2a5919413ec45e56 in total

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 1533f64dd3fcf233864f5dc9820ed9d619fa835d and 1 for PR HEAD f3c27b80649cb1f2b94c22ba2a5919413ec45e56 in total

jgbernalp commented 2 weeks ago

/retest-required

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 2bce638433c00eebdcbb96c0b68ce2005bc2cf4e and 0 for PR HEAD f3c27b80649cb1f2b94c22ba2a5919413ec45e56 in total

openshift-ci-robot commented 2 weeks ago

/hold

Revision f3c27b80649cb1f2b94c22ba2a5919413ec45e56 was retested 3 times: holding

jgbernalp commented 1 week ago

/test e2e-gcp-console

jgbernalp commented 1 week ago

/unhold

reestr commented 1 week ago

/label px-approved

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 3a115ff37f121c8a03679e9dc5303785ab1f6b9b and 2 for PR HEAD f3c27b80649cb1f2b94c22ba2a5919413ec45e56 in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 4df2ddc4aa941a2916279983fdc27b0a29b64268 and 2 for PR HEAD f3c27b80649cb1f2b94c22ba2a5919413ec45e56 in total

openshift-ci[bot] commented 1 week ago

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@jgbernalp: Jira Issue OCPBUGS-31367: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31367 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14464): >This PR adds external labels to Redux alerts to hide silenced alerts from notifications. > > >https://github.com/user-attachments/assets/449733fd-204e-479a-b219-282ed55832e7 > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411130408.p0.g4ca6d0a.assembly.stream.el9. All builds following this will include this PR.

jgbernalp commented 3 days ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 3 days ago

@jgbernalp: new pull request created: #14511

In response to [this](https://github.com/openshift/console/pull/14464#issuecomment-2484966719): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.