search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-44049: conditionally display MachineConfig details page Confi… #14468

Closed rhamilto closed 1 week ago

rhamilto commented 2 weeks ago

…guration files details

Based on my reading of the Ignition Config Spec, only path is required, so make the display of the other properties optional.

After

https://github.com/user-attachments/assets/f64cf269-2578-4f68-a02d-0c05116ad932

openshift-ci-robot commented 2 weeks ago

@rhamilto: This pull request references Jira Issue OCPBUGS-44049, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14468): >…guration files details > >Based on my reading of [the Ignition Config Spec](https://coreos.github.io/ignition/configuration-v3_5/), only `path` is required, so make the display of the other properties optional. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@rhamilto: This pull request references Jira Issue OCPBUGS-44049, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14468#issuecomment-2457507362): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@rhamilto: This pull request references Jira Issue OCPBUGS-44049, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14468#issuecomment-2457515700): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 2 weeks ago

/assign @jhadvig

rhamilto commented 2 weeks ago

/retest

rhamilto commented 2 weeks ago

/retest

rhamilto commented 2 weeks ago

/retest

cyril-ui-developer commented 1 week ago

/lgtm

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [cyril-ui-developer,rhamilto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhamilto commented 1 week ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 1 week ago

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/console/pull/14468#issuecomment-2468434372): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rhamilto commented 1 week ago

/retest

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 8eba12529f6224e1ac705f8a77a5799cf36edc34 and 2 for PR HEAD 3fd49b8422e05cffa449a6add32b61ffc2366846 in total

openshift-ci[bot] commented 1 week ago

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@rhamilto: Jira Issue OCPBUGS-44049: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44049 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14468): >…guration files details > >Based on my reading of [the Ignition Config Spec](https://coreos.github.io/ignition/configuration-v3_5/), only `path` is required, so make the display of the other properties optional. > >After > >https://github.com/user-attachments/assets/f64cf269-2578-4f68-a02d-0c05116ad932 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 week ago

@rhamilto: new pull request created: #14488

In response to [this](https://github.com/openshift/console/pull/14468#issuecomment-2468434372): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.19.0-202411130005.p0.g701dcf1.assembly.stream.el9. All builds following this will include this PR.