Closed rhamilto closed 5 days ago
@rhamilto: This pull request references CONSOLE-4268 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
@rhamilto: This pull request references CONSOLE-4268 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
@rhamilto: This pull request references CONSOLE-4268 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @reestr
@rhamilto: This pull request references CONSOLE-4268 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
/test frontend
/lgtm
LGTM on the last commit with actual changes for the plugin dashboard status.
@rhamilto is the WIP still valid ?
@rhamilto is the WIP still valid ?
Yes and no. It's WIP because it dependent on https://github.com/openshift/console/pull/14374 which has yet to merge, but the work to complete the story is done.
@rhamilto: This pull request references CONSOLE-4268 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
@rhamilto: This pull request references CONSOLE-4268 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
/test e2e-gcp-console
/lgtm
QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @reestr
Also worth to notice that this PR is cherry-picking CONSOLE-4264: Notify users of Console plugin related Content Security Policy violations and also contributing a fix for issue found by @yapei.
@opayne1 please review only commits contributed by @rhamilto, since @vojtechszocs was already reviewed by you. @yapei please test only functionality related to the CSP violations to cluster dashboard. Thank you 🙌
@rhamilto: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh
.
@rhamilto: This pull request references CONSOLE-4268 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
/label qe-approved
@rhamilto: This pull request references CONSOLE-4268 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
/label px-approved
/lgtm
/retest-required
Remaining retests: 0 against base HEAD 3b333aa62d9497bde010d7a2c18dd1773ec6744f and 2 for PR HEAD c90e2ce4e4c179bc91a7089a1b3dfbfa7c7c29e0 in total
@jhadvig, I had to rebase since https://github.com/openshift/console/pull/14487 merged first. Please retag.
/retest
/retest
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, rhamilto, vojtechszocs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 048685c4294266175f651a03ae1df1e545d73938 and 2 for PR HEAD d8871155b4913a7c684c5afa9a732bed0bb1e34c in total
@rhamilto: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.19.0-202411170238.p0.gf3e86e5.assembly.stream.el9. All builds following this will include this PR.
Includes changes from https://github.com/openshift/console/pull/14374, which should merge first. Note https://github.com/openshift/console/pull/14374 includes a bug that needs to be addressed where not Loaded plugins do not appear in the
Console plugins
list.Testing setup
To force a CSP violation in
console-demo-plugin
, addfetch('https://catfact.ninja/fact')
to line 4 of https://github.com/openshift/console/blob/master/dynamic-demo-plugin/src/utils/example-navs.tsx, rebuild and restart the plugin, and visit http://localhost:9000/dynamic-route-1.Demo
The alert in the Dynamic Plugins popover is the addition. (Disregard the tooltip clipping at the end; that's the result of the recording being made with the browser's dev tools open.)
https://github.com/user-attachments/assets/3a80069e-039c-4400-8d51-612026b18cf9