search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

[release-4.17] OCPBUGS-44358: BuildConfig form breaks on manually enter the Git URL #14478

Closed openshift-cherrypick-robot closed 5 days ago

openshift-cherrypick-robot commented 2 weeks ago

This is an automated cherry-pick of #14449

/assign lokanandaprabhu

openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-43925 has been cloned as Jira Issue OCPBUGS-44358. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-44358: BuildConfig form breaks on manually enter the Git URL

In response to [this](https://github.com/openshift/console/pull/14478): >This is an automated cherry-pick of #14449 > >/assign lokanandaprabhu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-44358, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14478): >This is an automated cherry-pick of #14449 > >/assign lokanandaprabhu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lokanandaprabhu commented 2 weeks ago

Tested using cluster bot. Working fine.

https://github.com/user-attachments/assets/60473979-bb4e-4eb2-a4fe-17d6eea2a27d

/lgtm /approve

openshift-ci[bot] commented 2 weeks ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, openshift-cherrypick-robot, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/dev-console/OWNERS](https://github.com/openshift/console/blob/release-4.17/frontend/packages/dev-console/OWNERS)~~ [lokanandaprabhu,vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lokanandaprabhu commented 6 days ago

/jira refresh

openshift-ci-robot commented 6 days ago

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-44358, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-43925](https://issues.redhat.com//browse/OCPBUGS-43925) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-43925](https://issues.redhat.com//browse/OCPBUGS-43925) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14478#issuecomment-2485715647): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
The-Anton commented 6 days ago

/label cherry-pick-approved

openshift-ci-robot commented 5 days ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-44358: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44358 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14478): >This is an automated cherry-pick of #14449 > >/assign lokanandaprabhu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 5 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.17.0-202411201434.p0.gbf19c40.assembly.stream.el9. All builds following this will include this PR.

lokanandaprabhu commented 4 days ago

/cherrypick release-4.16

openshift-cherrypick-robot commented 4 days ago

@lokanandaprabhu: #14478 failed to apply on top of branch "release-4.16":

Applying: Handled BC form breaking issue on typing git url
Using index info to reconstruct a base tree...
A   frontend/packages/dev-console/src/components/import/git/GitTypeSelector.tsx
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): frontend/packages/dev-console/src/components/import/git/GitTypeSelector.tsx deleted in HEAD and modified in Handled BC form breaking issue on typing git url. Version Handled BC form breaking issue on typing git url of frontend/packages/dev-console/src/components/import/git/GitTypeSelector.tsx left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Handled BC form breaking issue on typing git url
In response to [this](https://github.com/openshift/console/pull/14478#issuecomment-2492878756): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lokanandaprabhu commented 4 days ago

Issue is not present in OCP 4.16