search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

CONSOLE-4330: Remove Developer perspective > Observe > Silences tab #14480

Closed zhuje closed 1 week ago

zhuje commented 2 weeks ago

Related issues

OU JIRA issue

https://issues.redhat.com/browse/OU-257

CONSOLE JIRA issue

This duplicate issue was created because openshift/console github bots require a valid CONSOLE Jira to be associated with all PRs. https://issues.redhat.com/browse/CONSOLE-4330

Corresponding PR to migrate Dev > Observe > Silences Tab to openshift/monitoring-plugin

https://github.com/openshift/monitoring-plugin/pull/252

Description

To consolidate the code between the Developer and Administrative perspectives, the Developer View > Observe > Silences Tab is being moved from openshift/console to openshift/monitoring-plugin.

Testing Notes

zhuje commented 2 weeks ago

/hold

HOLD pending approval of https://github.com/openshift/monitoring-plugin/pull/252

logonoff commented 1 week ago

/retitle CONSOLE-4330: Remove Developer perspective > Observe > Silences tab

openshift-ci-robot commented 1 week ago

@zhuje: This pull request references CONSOLE-4330 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14480): >## Related issues > >### OU JIRA issue >https://issues.redhat.com/browse/OU-257 > >### CONSOLE JIRA issue >This duplicate issue was created because openshift/console github bots require a valid CONSOLE Jira to be associated with all PRs. >https://issues.redhat.com/browse/CONSOLE-4330 > >### Corresponding PR to migrate Dev > Observe > Silences Tab to `openshift/monitoring-plugin` >https://github.com/openshift/monitoring-plugin/pull/252 > >## Description >To consolidate the code between the Developer and Administrative perspectives, the Developer View > Observe > Silences Tab is being moved from openshift/console to openshift/monitoring-plugin. > >- This PR removes the 'Silences' tab in the openshift/console. >- The corresponding PR renders the 'Silences' tab in the openshift/monitoring-plugin: https://github.com/openshift/monitoring-plugin/pull/252 > >## Testing Notes >- The `Developer View > Observe > Silences Tab` should not appear if you run the console without the monitoring-plugin. >- The `Developer View > Observe > Silences Tab` should appear once you run the monitoring-plugin that includes this PR: https://github.com/openshift/monitoring-plugin/pull/252 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4330 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14480#issuecomment-2474086232): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
juzhao commented 1 week ago

tested https://github.com/openshift/monitoring-plugin/pull/252 https://github.com/openshift/console/pull/14480 with cluster-bot launch 4.18.0-0.nightly-2024-11-14-090045,openshift/monitoring-plugin#252,openshift/console#14480 aws there is one regression bug: OCPBUGS-44594

juzhao commented 1 week ago

tested again launch 4.18,openshift/monitoring-plugin#252,openshift/console#14480 aws OCPBUGS-44594 is fixed

juzhao commented 1 week ago

/label qe-approved

openshift-ci-robot commented 1 week ago

@zhuje: This pull request references CONSOLE-4330 which is a valid jira issue.

In response to [this](https://github.com/openshift/console/pull/14480): >## Related issues > >### OU JIRA issue >https://issues.redhat.com/browse/OU-257 > >### CONSOLE JIRA issue >This duplicate issue was created because openshift/console github bots require a valid CONSOLE Jira to be associated with all PRs. >https://issues.redhat.com/browse/CONSOLE-4330 > >### Corresponding PR to migrate Dev > Observe > Silences Tab to `openshift/monitoring-plugin` >https://github.com/openshift/monitoring-plugin/pull/252 > >## Description >To consolidate the code between the Developer and Administrative perspectives, the Developer View > Observe > Silences Tab is being moved from openshift/console to openshift/monitoring-plugin. > >- This PR removes the 'Silences' tab in the openshift/console. >- The corresponding PR renders the 'Silences' tab in the openshift/monitoring-plugin: https://github.com/openshift/monitoring-plugin/pull/252 > >## Testing Notes >- The `Developer View > Observe > Silences Tab` should not appear if you run the console without the monitoring-plugin. >- The `Developer View > Observe > Silences Tab` should appear once you run the monitoring-plugin that includes this PR: https://github.com/openshift/monitoring-plugin/pull/252 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikram-raj, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/dev-console/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/dev-console/OWNERS)~~ [vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhuje commented 1 week ago

/label docs-approved /label px-approved

No Docs of Product approval needed because this PR just refactors code. No new features were added.

zhuje commented 1 week ago

/unhold

https://github.com/openshift/monitoring-plugin/pull/252 has merged and has been reviewed by QE.

openshift-bot commented 6 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411182236.p0.g65a1fb8.assembly.stream.el9. All builds following this will include this PR.