search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

[release-4.13] OCPBUGS-36557: Increase login flow state paramater length/entropy #14483

Closed openshift-cherrypick-robot closed 4 days ago

openshift-cherrypick-robot commented 1 week ago

This is an automated cherry-pick of #14439

/assign jhadvig

openshift-ci-robot commented 1 week ago

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-36558 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.13] OCPBUGS-36557: Increase login flow state paramater length/entropy

In response to [this](https://github.com/openshift/console/pull/14483): >This is an automated cherry-pick of #14439 > >/assign jhadvig Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36557, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14483): >This is an automated cherry-pick of #14439 > >/assign jhadvig Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
TheRealJon commented 1 week ago

/retest

TheRealJon commented 1 week ago

/label backport-risk-assessed

TheRealJon commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-36557, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console/pull/14483#issuecomment-2483154904): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
spadgett commented 5 days ago

/cherry-pick release-4.12

openshift-cherrypick-robot commented 5 days ago

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/console/pull/14483#issuecomment-2488833659): >/cherry-pick release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/auth/OWNERS](https://github.com/openshift/console/blob/release-4.13/pkg/auth/OWNERS)~~ [spadgett] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
TheRealJon commented 5 days ago

/jira refresh

openshift-ci-robot commented 5 days ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-36557, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-36558](https://issues.redhat.com//browse/OCPBUGS-36558) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36558](https://issues.redhat.com//browse/OCPBUGS-36558) targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z * bug has dependents

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14483#issuecomment-2489019394): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanpzhan commented 4 days ago

Checked on cluster launched against the pr, accessed console url, checked "state" parameter in login redirect url, it's 16 bytes. /label qe-approved /label cherry-pick-approved

openshift-ci-robot commented 4 days ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36557, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-36558](https://issues.redhat.com//browse/OCPBUGS-36558) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36558](https://issues.redhat.com//browse/OCPBUGS-36558) targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z * bug has dependents

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14483): >This is an automated cherry-pick of #14439 > >/assign jhadvig Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 days ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 days ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36557: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36557 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14483): >This is an automated cherry-pick of #14439 > >/assign jhadvig Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 4 days ago

@spadgett: #14483 failed to apply on top of branch "release-4.12":

Applying: OCPBUGS-38907: Increase login flow state paramater length/entropy
Using index info to reconstruct a base tree...
M   pkg/auth/auth.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/auth/auth.go
CONFLICT (content): Merge conflict in pkg/auth/auth.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-38907: Increase login flow state paramater length/entropy
In response to [this](https://github.com/openshift/console/pull/14483#issuecomment-2488833659): >/cherry-pick release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 4 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.13.0-202411212034.p0.gc5d8e96.assembly.stream.el8. All builds following this will include this PR.

openshift-merge-robot commented 2 days ago

Fix included in accepted release 4.13.0-0.nightly-2024-11-23-101305