Open TheRealJon opened 1 week ago
/lgtm
We should test this on a production build of Console deployed on the cluster.
This PR should address https://github.com/openshift/console/pull/14156#issuecomment-2389109315
QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @reestr
/label docs-approved
/label px-approved
/hold Looks like we need to updated the unit tests
Hmm not sure why the asynccache test failed but might be a flake, since there is no relevant change and also the search page is not suggesting otherwise.
/retest /lgtm
@yapei could you please take a look at this PR? thank you !
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jhadvig, TheRealJon, vojtechszocs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
@TheRealJon @jhadvig This can be a bug rather than a story.
/hold
/retest
/lgtm cancel
/retest
@opayne1 I've addressed your comments, thanks
@TheRealJon: This pull request references Jira Issue OCPBUGS-44852, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
/jira refresh /label tide/merge-method-squash
@TheRealJon: This pull request references Jira Issue OCPBUGS-44852, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @yapei
@TheRealJon: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/backend | c044d898bd422d855f66443f9276f774754852ea | link | true | /test backend |
ci/prow/e2e-gcp-console | c044d898bd422d855f66443f9276f774754852ea | link | true | /test e2e-gcp-console |
ci/prow/okd-scos-e2e-aws-ovn | c044d898bd422d855f66443f9276f774754852ea | link | false | /test okd-scos-e2e-aws-ovn |
Full PR test history. Your PR dashboard.
/label qe-approved
@TheRealJon: This pull request references Jira Issue OCPBUGS-44852, which is valid.
Requesting review from QA contact: /cc @yapei
@TheRealJon: This pull request references CONSOLE-4331 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.