openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-44852: Add ocm and telemetry urls to csp allowlist #14485

Open TheRealJon opened 1 week ago

openshift-ci-robot commented 1 week ago

@TheRealJon: This pull request references CONSOLE-4331 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14485): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vojtechszocs commented 1 week ago

/lgtm

We should test this on a production build of Console deployed on the cluster.

vojtechszocs commented 1 week ago

This PR should address https://github.com/openshift/console/pull/14156#issuecomment-2389109315

jhadvig commented 1 week ago

QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @reestr

opayne1 commented 1 week ago

/label docs-approved

reestr commented 1 week ago

/label px-approved

jhadvig commented 3 days ago

/hold Looks like we need to updated the unit tests

jhadvig commented 2 days ago

Hmm not sure why the asynccache test failed but might be a flake, since there is no relevant change and also the search page is not suggesting otherwise.

/retest /lgtm

@yapei could you please take a look at this PR? thank you !

openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/OWNERS](https://github.com/openshift/console/blob/master/pkg/OWNERS)~~ [TheRealJon,jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jhadvig commented 2 days ago

/hold cancel

spadgett commented 2 days ago

@TheRealJon @jhadvig This can be a bug rather than a story.

/hold

TheRealJon commented 1 day ago

/retest

spadgett commented 1 day ago

/lgtm cancel

jhadvig commented 1 day ago

/retest

TheRealJon commented 22 hours ago

@opayne1 I've addressed your comments, thanks

openshift-ci-robot commented 21 hours ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-44852, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14485): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
TheRealJon commented 20 hours ago

/jira refresh /label tide/merge-method-squash

openshift-ci-robot commented 20 hours ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-44852, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14485#issuecomment-2492003264): >/jira refresh >/label tide/merge-method-squash Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 17 hours ago

@TheRealJon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/backend c044d898bd422d855f66443f9276f774754852ea link true /test backend
ci/prow/e2e-gcp-console c044d898bd422d855f66443f9276f774754852ea link true /test e2e-gcp-console
ci/prow/okd-scos-e2e-aws-ovn c044d898bd422d855f66443f9276f774754852ea link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yapei commented 14 hours ago

/label qe-approved

openshift-ci-robot commented 14 hours ago

@TheRealJon: This pull request references Jira Issue OCPBUGS-44852, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14485): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.