search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

CONSOLE-4073,CONSOLE-4074: Refactor Pull Secret forms #14490

Open TheRealJon opened 1 week ago

TheRealJon commented 1 week ago

Refactor CreateConfigSubForm, PullSecretCredentialsForm, PullSecretCredentialEntry, and UploadConfigSubForm.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [TheRealJon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 week ago

@TheRealJon: This pull request references CONSOLE-4073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4074 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14490): >Refactor CreateConfigSubForm, PullSecretCredentialsForm, PullSecretCredentialEntry, and UploadConfigSubForm. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
TheRealJon commented 1 week ago

/label tide/merge-method-squash

TheRealJon commented 1 week ago

QE Approver /assign @yapei

Docs Approver: /assign @opayne1

PX Approver: /assign @reestr

TheRealJon commented 1 week ago

This PR contains the same changes as https://github.com/openshift/console/pull/14052, just from my branch to help expedite any further changes.

yapei commented 1 week ago

@XiyunZhao will work on PR testing and will report back once complete

XiyunZhao commented 1 week ago

This PR has been tested (regression and manual testing) without any issue, the refactor for pull secret forms works as expected /label qe-approved

openshift-ci-robot commented 1 week ago

@TheRealJon: This pull request references CONSOLE-4073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4074 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14490): >Refactor CreateConfigSubForm, PullSecretCredentialsForm, PullSecretCredentialEntry, and UploadConfigSubForm. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
XiyunZhao commented 1 week ago

/test e2e-gcp-console

Mylanos commented 1 week ago

/retest

XiyunZhao commented 6 days ago

/test e2e-gcp-console

opayne1 commented 5 days ago

/label docs-approved

TheRealJon commented 5 days ago

/retest

reestr commented 4 days ago

/label px-approved

jhadvig commented 4 days ago

@TheRealJon it looks like there is an issue with circular deps.

ERROR in HandleCyclesPlugin: total cycles (6) exceeds threshold (0)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Cycle(s) detected!
webpack compilation 58257e946acaf5ce0243
6 total cycles, 0 min-length cycles (A -> B -> A)
Cycle count per directory:
  public (6)
Index files occurring within cycles:
  public/components/secrets/create-secret/index.tsx (5)
/go/src/github.com/openshift/console/frontend/public/components/secrets/create-secret/index.tsx
  public/components/secrets/create-secret/index.tsx
  public/components/secrets/create-secret/SecretFormWrapper.tsx
  public/components/secrets/create-secret/SecretSubForm.tsx
  public/components/secrets/create-secret/WebHookSecretForm.tsx
  public/components/secrets/create-secret/index.tsx
/go/src/github.com/openshift/console/frontend/public/components/secrets/create-secret/SecretFormWrapper.tsx
  public/components/secrets/create-secret/SecretFormWrapper.tsx
  public/components/secrets/create-secret/SecretSubForm.tsx
  public/components/secrets/create-secret/WebHookSecretForm.tsx
  public/components/secrets/create-secret/index.tsx
  public/components/secrets/create-secret/SecretFormWrapper.tsx
/go/src/github.com/openshift/console/frontend/public/components/secrets/create-secret/SecretSubForm.tsx
  public/components/secrets/create-secret/SecretSubForm.tsx
  public/components/secrets/create-secret/WebHookSecretForm.tsx
  public/components/secrets/create-secret/index.tsx
  public/components/secrets/create-secret/SecretFormWrapper.tsx
  public/components/secrets/create-secret/SecretSubForm.tsx
/go/src/github.com/openshift/console/frontend/public/components/secrets/create-secret/WebHookSecretForm.tsx
  public/components/secrets/create-secret/WebHookSecretForm.tsx
  public/components/secrets/create-secret/index.tsx
  public/components/secrets/create-secret/SecretFormWrapper.tsx
  public/components/secrets/create-secret/SecretSubForm.tsx
  public/components/secrets/create-secret/WebHookSecretForm.tsx
/go/src/github.com/openshift/console/frontend/public/components/secrets/create-secret/EditSecret.tsx
  public/components/secrets/create-secret/EditSecret.tsx
  public/components/secrets/create-secret/SecretFormWrapper.tsx
  public/components/secrets/create-secret/SecretSubForm.tsx
  public/components/secrets/create-secret/WebHookSecretForm.tsx
  public/components/secrets/create-secret/index.tsx
  public/components/secrets/create-secret/EditSecret.tsx
/go/src/github.com/openshift/console/frontend/public/components/secrets/create-secret/CreateSecret.tsx
  public/components/secrets/create-secret/CreateSecret.tsx
  public/components/secrets/create-secret/SecretFormWrapper.tsx
  public/components/secrets/create-secret/SecretSubForm.tsx
  public/components/secrets/create-secret/WebHookSecretForm.tsx
  public/components/secrets/create-secret/index.tsx
  public/components/secrets/create-secret/CreateSecret.tsx
jhadvig commented 3 days ago

/retest

TheRealJon commented 3 days ago

/retest

openshift-ci[bot] commented 3 days ago

@TheRealJon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console d28e42586c0d278042af51f6a45eb60bf3283a98 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).