search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-44566: Address circular references in `packages/knative-plugin` #14492

Closed logonoff closed 1 week ago

logonoff commented 1 week ago

Fixes:

Fixes: https://issues.redhat.com/browse/OCPBUGS-44566

Analysis / Root cause:

Barrel imports caused circular references

Solution Description:

Replace index.ts/barrel imports with their direct counterparts

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

Run yarn check-cycles and observe that there are no more cycles involving the knative-plugin/src/topology folder, excluding cycles with module paths that match the regex /node_modules|public\/dist|@console\/active-plugins/ (those will be addressed in separate PRs)

Browser conformance:

This is 1 of many PRs to inch towards closing OCPBUGS-44017

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references Jira Issue OCPBUGS-44566, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14492): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/OCPBUGS-44566 > >**Analysis / Root cause**: > >Barrel imports caused circular references > >**Solution Description**: > >Replace `index.ts`/barrel imports with their direct counterparts > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Run `yarn check-cycles` and observe that there are no more cycles involving the `knative-plugin/src/topology` folder, excluding cycles with module paths that match the regex `/node_modules|public\/dist|@console\/active-plugins/` > >**Browser conformance**: > >- [ ] Chrome >- [ ] Firefox >- [ ] Safari > >This is 1 of many PR Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@logonoff: This pull request references Jira Issue OCPBUGS-44566, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14492): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/OCPBUGS-44566 > >**Analysis / Root cause**: > >Barrel imports caused circular references > >**Solution Description**: > >Replace `index.ts`/barrel imports with their direct counterparts > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Run `yarn check-cycles` and observe that there are no more cycles involving the `knative-plugin/src/topology` folder, excluding cycles with module paths that match the regex `/node_modules|public\/dist|@console\/active-plugins/` > >**Browser conformance**: > >- [ ] Chrome >- [ ] Firefox >- [ ] Safari > >This is 1 of many PRs to inch towards closing [OCPBUGS-44017](https://issues.redhat.com/browse/OCPBUGS-44017) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@logonoff: This pull request references Jira Issue OCPBUGS-44566, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14492): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/OCPBUGS-44566 > >**Analysis / Root cause**: > >Barrel imports caused circular references > >**Solution Description**: > >Replace `index.ts`/barrel imports with their direct counterparts > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Run `yarn check-cycles` and observe that there are no more cycles involving the `knative-plugin/src/topology` folder, excluding cycles with module paths that match the regex `/node_modules|public\/dist|@console\/active-plugins/` (those will be addressed in separate PRs) > >**Browser conformance**: > >- [ ] Chrome >- [ ] Firefox >- [ ] Safari > >This is 1 of many PRs to inch towards closing [OCPBUGS-44017](https://issues.redhat.com/browse/OCPBUGS-44017) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 1 week ago

for code review

/cc @Lucifergene

logonoff commented 1 week ago

/retest

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/knative-plugin/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/knative-plugin/OWNERS)~~ [spadgett] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
logonoff commented 1 week ago

/retest

logonoff commented 1 week ago

/retest

openshift-ci[bot] commented 1 week ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@logonoff: Jira Issue OCPBUGS-44566: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44566 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14492): >**Fixes**: > >Fixes: https://issues.redhat.com/browse/OCPBUGS-44566 > >**Analysis / Root cause**: > >Barrel imports caused circular references > >**Solution Description**: > >Replace `index.ts`/barrel imports with their direct counterparts > >**Screen shots / Gifs for design review**: > >n/a > >**Unit test coverage report**: > >n/a > >**Test setup:** > >Run `yarn check-cycles` and observe that there are no more cycles involving the `knative-plugin/src/topology` folder, excluding cycles with module paths that match the regex `/node_modules|public\/dist|@console\/active-plugins/` (those will be addressed in separate PRs) > >**Browser conformance**: > >- [ ] Chrome >- [ ] Firefox >- [ ] Safari > >This is 1 of many PRs to inch towards closing [OCPBUGS-44017](https://issues.redhat.com/browse/OCPBUGS-44017) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411151408.p0.g3b333aa.assembly.stream.el9. All builds following this will include this PR.