Closed logonoff closed 5 days ago
@logonoff: This pull request references Jira Issue OCPBUGS-44567, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @sanketpathak
The bug has been updated to refer to the pull request using the external bug tracker.
for code review
/cc @lokanandaprabhu
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, spadgett
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
/retest
/retest
/retest-required
Remaining retests: 0 against base HEAD 048685c4294266175f651a03ae1df1e545d73938 and 2 for PR HEAD 854a58a25a7076ae12b5de1d98c1c946f45b0e20 in total
/retest
/retest
@logonoff: all tests passed!
Full PR test history. Your PR dashboard.
@logonoff: Jira Issue OCPBUGS-44567: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-44567 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411171037.p0.gcb576e5.assembly.stream.el9. All builds following this will include this PR.
Fixes:
Fixes: https://issues.redhat.com/browse/OCPBUGS-44566
Analysis / Root cause:
Barrel imports caused circular references
Solution Description:
Replace
index.ts
/barrel imports with their direct counterpartsScreen shots / Gifs for design review:
n/a
Unit test coverage report:
n/a
Test setup:
Run
yarn check-cycles
and observe that there are no more cycles involving thepackages/pipelines-plugin
folder, excluding cycles with module paths that match the regex/node_modules|public\/dist|@console\/active-plugins/
(those will be addressed in separate PRs)Browser conformance:
This is 1 of many PRs to inch towards closing OCPBUGS-44017