Closed logonoff closed 6 days ago
@logonoff: This pull request references Jira Issue OCPBUGS-44574, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @yapei
The bug has been updated to refer to the pull request using the external bug tracker.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: logonoff, spadgett
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
@logonoff: all tests passed!
Full PR test history. Your PR dashboard.
@logonoff: Jira Issue OCPBUGS-44574: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-44574 has been moved to the MODIFIED state.
Fixes:
Fixes: https://issues.redhat.com/browse/OCPBUGS-44574
Analysis / Root cause:
Barrel imports caused circular references
Solution Description:
Replace
index.ts
/barrel imports with their direct counterpartsScreen shots / Gifs for design review:
n/a
Unit test coverage report:
n/a
Test setup:
Run
yarn check-cycles
and observe that there are no more cycles involving thepackages/webterminal-plugin
andpackages/console-app
folder, excluding cycles with module paths that match the regex/node_modules|public\/dist|@console\/active-plugins/
(those will be addressed in separate PRs)Browser conformance:
This is 1 of many PRs to inch towards closing OCPBUGS-44017