openshift-ci-robot
commented
6 days ago @logonoff: This pull request references Jira Issue OCPBUGS-44576, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)Requesting review from QA contact: /cc @yapei
The bug has been updated to refer to the pull request using the external bug tracker.
In response to [this](https://github.com/openshift/console/pull/14500):
>**Fixes**:
>
>Fixes: https://issues.redhat.com/browse/OCPBUGS-44576
>
>**Analysis / Root cause**:
>
>Barrel imports / large files caused circular references
>
>**Solution Description**:
>
>Replace `index.ts`/barrel imports with their direct counterparts, split up some large files
>
>**Screen shots / Gifs for design review**:
>
>n/a
>
>**Unit test coverage report**:
>
>n/a
>
>**Test setup:**
>
>Run `yarn check-cycles` and observe that there are no more cycles involving `pubic` folder, excluding cycles with module paths that match the regex `/node_modules|public\/dist|@console\/active-plugins/` (those will be addressed in separate PRs), and excluding these cycles (because they are false positives)
>
>```
>openshift/console/frontend/public/tokener.html
> public/tokener.html
> public/tokener.html
>
>openshift/console/frontend/public/index.html
> public/index.html
> public/index.html
>
>openshift/console/frontend/public/actions/features.gql
> public/actions/features.gql
> public/actions/features.gql
>
>openshift/console/frontend/public/graphql/client.gql
> public/graphql/client.gql
> public/graphql/client.gql
>```
>
>
>
>**Browser conformance**:
>
>- [ ] Chrome
>- [ ] Firefox
>- [ ] Safari
>
>This is 1 of many PRs to inch towards closing [OCPBUGS-44017](https://issues.redhat.com/browse/OCPBUGS-44017)
Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff
openshift-ci[bot]
openshift-bot
Fixes:
Fixes: https://issues.redhat.com/browse/OCPBUGS-44576
Analysis / Root cause:
Barrel imports / large files caused circular references
Solution Description:
Replace
index.ts/barrel imports with their direct counterparts, split up some large filesScreen shots / Gifs for design review:
n/a
Unit test coverage report:
n/a
Test setup:
Run
yarn check-cyclesand observe that there are no more cycles involvingpubicfolder, excluding cycles with module paths that match the regex/node_modules|public\/dist|@console\/active-plugins/(those will be addressed in separate PRs), and excluding these cycles (because they are false positives)Browser conformance:
This PR also closes OCPBUGS-44017