CONSOLE-4355: Add circular deps detection to `ci/prow/frontend` - Githubissues

openshift / console

OpenShift Cluster Console UI

https://www.openshift.org

Apache License 2.0

401 stars 613 forks source link

CONSOLE-4355: Add circular deps detection to `ci/prow/frontend` #14501

Closed logonoff closed 5 days ago

logonoff commented 1 week ago

CONSOLE Features and Fixes:

Features: https://issues.redhat.com/browse/CONSOLE-4355

Solution description

Update webpack.circular-deps.ts to filter out the plugins registry (@console/active-plugins), and run yarn check-cycles on test-frontend.sh

Reviewers and assignees:

Console Approver: /assign @spadgett

Test cases:

When ./test-frontend.sh detects a cycle, it should print out the .webpack-cycles report before exiting
When no cycles are detected, ./test-frontend.sh should continue to run as normal

Additional info:

n/a

Screen shots / gifs / design review:

n/a

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4335 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> > >Features: https://issues.redhat.com/browse/CONSOLE-4335 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> >Console Approver: >/assign @spadgett > >QE approver: >/assign @sanketpathak > >

Test cases:

> >n/a > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

logonoff commented 1 week ago

/hold

This PR depends on the following PRs to merge first for tests to pass:

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4355 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> > >Features: https://issues.redhat.com/browse/CONSOLE-4335 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> >Console Approver: >/assign @spadgett > >QE approver: >/assign @sanketpathak > >

Test cases:

> >n/a > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4355 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> > >Features: https://issues.redhat.com/browse/CONSOLE-4355 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> > >Console Approver: >/assign @spadgett > >QE approver: >/assign @sanketpathak >/assign @yapei > >

Test cases:

> >n/a > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4355 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> > >Features: https://issues.redhat.com/browse/CONSOLE-4355 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> >Console Approver: >/assign @spadgett > >QE approver: >/assign @sanketpathak >/assign @yapei > >

Test cases:

> >n/a > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4355 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> > >Features: https://issues.redhat.com/browse/CONSOLE-4355 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> >Console Approver: >/assign @spadgett > >QE approver: >/assign @sanketpathak >/assign @yapei > >

Test cases:

> >When `./test-frontend.sh` detects a cycle, it should print out the `.webpack-cycles` report before exiting > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4355 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> >Features: https://issues.redhat.com/browse/CONSOLE-4355 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> >Console Approver: >/assign @spadgett > >QE approver: >/assign @sanketpathak >/assign @yapei > >

Test cases:

> >When `./test-frontend.sh` detects a cycle, it should print out the `.webpack-cycles` report before exiting > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4355 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> >Features: https://issues.redhat.com/browse/CONSOLE-4355 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> >Console Approver: >/assign @spadgett > >

Test cases:

> >When `./test-frontend.sh` detects a cycle, it should print out the `.webpack-cycles` report before exiting > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

logonoff commented 1 week ago

manually adding labels for non-customer-facing ticket

/label docs-approved /label px-approved

QE approver: /assign @sanketpathak or /assign @yapei whoever has the time

yapei commented 1 week ago

looks good to me /label qe-approved

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4355 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> >Features: https://issues.redhat.com/browse/CONSOLE-4355 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> >Console Approver: >/assign @spadgett > >

Test cases:

> >When `./test-frontend.sh` detects a cycle, it should print out the `.webpack-cycles` report before exiting > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 1 week ago

@logonoff: This pull request references CONSOLE-4355 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14501): >

CONSOLE Features and Fixes:

> >Features: https://issues.redhat.com/browse/CONSOLE-4355 > >

Solution description

> > >Update `webpack.circular-deps.ts` to filter out the plugins registry (`@console/active-plugins`), and run `yarn check-cycles` on `test-frontend.sh` > >

Reviewers and assignees:

> >Console Approver: >/assign @spadgett > >

Test cases:

> >- When `./test-frontend.sh` detects a cycle, it should print out the `.webpack-cycles` report before exiting >- When no cycles are detected, `./test-frontend.sh` should continue to run as normal > >

Additional info:

> >n/a > >

Screen shots / gifs / design review:

> >n/a > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

logonoff commented 6 days ago

/unhold

logonoff commented 6 days ago

/retest /label acknowledge-critical-fixes-only

openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/console/blob/master/OWNERS)~~ [spadgett] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 5 days ago

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-bot commented 5 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411201308.p0.gc444b63.assembly.stream.el9. All builds following this will include this PR.