openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-44643: Community tasks are not persisting after cluster tasks are removed #14504

Closed lokanandaprabhu closed 6 days ago

lokanandaprabhu commented 1 week ago

Fixes: https://issues.redhat.com/browse/OCPBUGS-44643

Analysis / Root cause: While considering whether Tasks are present or not, only namespaced and cluster tasks were considered. Since Cluster tasks are deprecated from Pipelines 1.17 and namespaced tasks are also not created, community tasks were not listed.

Solution Description: Checks to consider only namespaced task or cluster task present or not while listing the tasks is removed.

Unit test coverage report: NA

Screenshots/Video

https://github.com/user-attachments/assets/5efabdc6-91e0-4386-a930-aef49310085a

Test setup:

1. Set the window.SERVER_FLAGS.GOARCH and window.SERVER_FLAGS.GOOS
2. Go to the pipeline builder page

Browser conformance:

openshift-ci-robot commented 1 week ago

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-44643, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14504): >**Fixes**: >https://issues.redhat.com/browse/OCPBUGS-44643 > >**Analysis / Root cause:** >While considering whether Tasks are present or not, only namespaced and cluster tasks were considered. Since Cluster tasks are deprecated from Pipelines 1.17 and namespaced tasks are also not created, community tasks were not listed. > >**Solution Description**: >Checks to consider only namespaced task or cluster task present or not while listing the tasks is removed. > > >**Unit test coverage report**: >NA > >** Screenshots/Video ** > > >https://github.com/user-attachments/assets/5efabdc6-91e0-4386-a930-aef49310085a > > >**Test setup:** > > 1. Set the window.SERVER_FLAGS.GOARCH and window.SERVER_FLAGS.GOOS > 2. Go to the pipeline builder page > > >**Browser conformance**: > >- [x] Chrome >- [ ] Firefox >- [ ] Safari >- [ ] Edge > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lokanandaprabhu commented 1 week ago

/cc @vikram-raj @The-Anton

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/pipelines-plugin/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/pipelines-plugin/OWNERS)~~ [lokanandaprabhu,vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lokanandaprabhu commented 1 week ago

/retest

openshift-ci[bot] commented 6 days ago

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 days ago

@lokanandaprabhu: Jira Issue OCPBUGS-44643: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44643 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/console/pull/14504): >**Fixes**: >https://issues.redhat.com/browse/OCPBUGS-44643 > >**Analysis / Root cause:** >While considering whether Tasks are present or not, only namespaced and cluster tasks were considered. Since Cluster tasks are deprecated from Pipelines 1.17 and namespaced tasks are also not created, community tasks were not listed. > >**Solution Description**: >Checks to consider only namespaced task or cluster task present or not while listing the tasks is removed. > > >**Unit test coverage report**: >NA > >** Screenshots/Video ** > > >https://github.com/user-attachments/assets/5efabdc6-91e0-4386-a930-aef49310085a > > >**Test setup:** > > 1. Set the window.SERVER_FLAGS.GOARCH and window.SERVER_FLAGS.GOOS > 2. Go to the pipeline builder page > > >**Browser conformance**: > >- [x] Chrome >- [ ] Firefox >- [ ] Safari >- [ ] Edge > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411190136.p0.gd92f5f8.assembly.stream.el9. All builds following this will include this PR.