search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-39388: Filter out empty params before Shipwright build creation #14514

Open vikram-raj opened 2 days ago

vikram-raj commented 2 days ago

Fixes: https://issues.redhat.com/browse/OCPBUGS-39388

Descriptions:

openshift-ci-robot commented 2 days ago

@vikram-raj: This pull request references Jira Issue OCPBUGS-39388, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14514): >Fixes: https://issues.redhat.com/browse/OCPBUGS-39388 > >Descriptions: >- Filter out empty params before Shipwright build creation as BuildRun fails if empty param values are passed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vikram-raj commented 2 days ago

/cc @lokanandaprabhu

openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/packages/shipwright-plugin/OWNERS](https://github.com/openshift/console/blob/master/frontend/packages/shipwright-plugin/OWNERS)~~ [vikram-raj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vikram-raj commented 2 days ago

/retest

vikram-raj commented 7 hours ago

/retest

openshift-ci[bot] commented 4 hours ago

@vikram-raj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3fdea0606e54aeaba0ba047dd9afe53983de1288 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).