openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

[WIP] CONSOLE-4269: enhancements based on feedback from @spadgett #14515

Closed rhamilto closed 1 day ago

rhamilto commented 2 days ago

Add Console plugins to nav

https://github.com/user-attachments/assets/344553e5-96e2-421b-937a-53c903edaab9

Add Dependencies to ConsolePlugins details page (note all the details in the video are not accurate such as Enabled)

https://github.com/user-attachments/assets/115f4b54-c895-4cd6-8b63-1875e8ad4d92

Replace CopyToClipboard with ResourceYAMLEditor on Plugin manifest tab

https://github.com/user-attachments/assets/787c3d4b-2959-4d1c-92db-c4ed10849ca8

openshift-ci-robot commented 2 days ago

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14515): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [rhamilto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 days ago

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14515): >Add `Console plugins` to nav > >https://github.com/user-attachments/assets/344553e5-96e2-421b-937a-53c903edaab9 > >Add `Dependencies` to ConsolePlugins details page (note all the details in the video are not accurate such as `Enabled`) > >https://github.com/user-attachments/assets/115f4b54-c895-4cd6-8b63-1875e8ad4d92 > >Replace `CopyToClipboard` with `ResourceYAMLEditor` on `Plugin manifest` tab > >https://github.com/user-attachments/assets/5b977750-8748-4f5a-8493-03996b4e4fe1 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 days ago

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/console/pull/14515): >Add `Console plugins` to nav > >https://github.com/user-attachments/assets/344553e5-96e2-421b-937a-53c903edaab9 > >Add `Dependencies` to ConsolePlugins details page (note all the details in the video are not accurate such as `Enabled`) > >https://github.com/user-attachments/assets/115f4b54-c895-4cd6-8b63-1875e8ad4d92 > >Replace `CopyToClipboard` with `ResourceYAMLEditor` on `Plugin manifest` tab > >https://github.com/user-attachments/assets/787c3d4b-2959-4d1c-92db-c4ed10849ca8 > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 days ago

@rhamilto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 316b88564bcd09b7f181145d70137224f09895f4 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-console 316b88564bcd09b7f181145d70137224f09895f4 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).