Open logonoff opened 6 days ago
@logonoff: This pull request references Jira Issue OCPBUGS-44759, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: logonoff Once this PR has been reviewed and has the lgtm label, please assign invinciblejai for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/jira refresh
@logonoff: This pull request references Jira Issue OCPBUGS-44759, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @sanketpathak
/label acknowledge-critical-fixes-only
/hold
blocked due to ongoing discussion of major refactor https://issues.redhat.com/browse/CONSOLE-4088
/remove-label acknowledge-critical-fixes-only
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/OCPBUGS-44759
Solution description
Ensure buffers are used when
isBinary
is used, also prefer the namedisBinary
export over importing the entire object to allow for easier tree shakingReviewers and assignees:
Console Approver: /assign @TheRealJon
Test cases:
n/a
Additional info:
n/a
Screen shots / gifs / design review:
n/a