openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-44759: Refactor `istextorbinary` to use correct types #14516

Open logonoff opened 6 days ago

logonoff commented 6 days ago

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/OCPBUGS-44759

Solution description

Ensure buffers are used when isBinary is used, also prefer the named isBinary export over importing the entire object to allow for easier tree shaking

Reviewers and assignees:

Console Approver: /assign @TheRealJon

Test cases:

n/a

Additional info:

n/a

Screen shots / gifs / design review:

n/a

openshift-ci-robot commented 6 days ago

@logonoff: This pull request references Jira Issue OCPBUGS-44759, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14516): >

CONSOLE Features and Fixes:

> > > >https://issues.redhat.com/browse/OCPBUGS-44759 > >

Solution description

> > >Ensure buffers are used when `isBinary` is used, also prefer the named `isBinary` export over importing the entire object to allow for easier tree shaking > >

Reviewers and assignees:

> > > Console Approver: > /assign @TheRealJon > > >

Test cases:

> > >n/a > >

Additional info:

> > >n/a > >

Screen shots / gifs / design review:

> > > >n/a Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff Once this PR has been reviewed and has the lgtm label, please assign invinciblejai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
logonoff commented 6 days ago

/jira refresh

openshift-ci-robot commented 6 days ago

@logonoff: This pull request references Jira Issue OCPBUGS-44759, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sanketpathak

In response to [this](https://github.com/openshift/console/pull/14516#issuecomment-2486656668): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
logonoff commented 6 days ago

/label acknowledge-critical-fixes-only

logonoff commented 6 days ago

/hold

blocked due to ongoing discussion of major refactor https://issues.redhat.com/browse/CONSOLE-4088

logonoff commented 5 days ago

/remove-label acknowledge-critical-fixes-only