search

openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

OCPBUGS-44800: Add Dynamic Plugins nav item #14521

Open rhamilto opened 2 days ago

rhamilto commented 2 days ago

localhost_9000_k8s_cluster_operator openshift io~v1~Console_cluster_console-plugins

openshift-ci-robot commented 2 days ago

@rhamilto: This pull request references Jira Issue OCPBUGS-44800, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14521): >Screenshot 2024-11-20 at 9 39 16 AM > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 2 days ago

We use the label Dynamic plugins in the Overview and the About modal (screenshots below), but I think Console Plugins is the proper choice for the nav item since that aligns with the tab label, but it is odd we have this discrepancy. Maybe we need to revisit? @jhadvig, @spadgett, @vojtechszocs, WDYT?

Screenshot 2024-11-20 at 9 53 05 AM Screenshot 2024-11-20 at 9 53 15 AM
rhamilto commented 1 day ago

/retest

rhamilto commented 1 day ago

/retest

rhamilto commented 1 day ago

/test okd-scos-e2e-aws-ovn

openshift-ci-robot commented 23 hours ago

@rhamilto: This pull request references Jira Issue OCPBUGS-44800, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yapei@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/console/pull/14521): >![localhost_9000_k8s_cluster_operator openshift io~v1~Console_cluster_console-plugins](https://github.com/user-attachments/assets/c2debaeb-ad90-4a09-885b-ebe8f1898e86) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rhamilto commented 23 hours ago

We use the label Dynamic plugins in the Overview and the About modal (screenshots below), but I think Console Plugins is the proper choice for the nav item since that aligns with the tab label, but it is odd we have this discrepancy. Maybe we need to revisit? @jhadvig, @spadgett, @vojtechszocs, WDYT?

In the light of a new day, I realized the nav item label should be Dynamic Plugins, so I've updated this PR.

rhamilto commented 19 hours ago

/label acknowledge-critical-fixes-only

vojtechszocs commented 19 hours ago

/lgtm

openshift-ci[bot] commented 19 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/master/frontend/OWNERS)~~ [rhamilto,vojtechszocs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
spadgett commented 18 hours ago

We use the label Dynamic plugins in the Overview and the About modal (screenshots below), but I think Console Plugins is the proper choice for the nav item since that aligns with the tab label, but it is odd we have this discrepancy. Maybe we need to revisit? @jhadvig, @spadgett, @vojtechszocs, WDYT?

IMO it should be "Console Plugins" everywhere. That's the only kind of plugin we've ever had an external API for. "Static plugins" were always an internal thing, so there's not a need to differentiate between them for users. I think putting "Dynamic" in the label raises more questions than it answers for most users. Also "Console Plugin" matches the CRD kind.

rhamilto commented 18 hours ago

We use the label Dynamic plugins in the Overview and the About modal (screenshots below), but I think Console Plugins is the proper choice for the nav item since that aligns with the tab label, but it is odd we have this discrepancy. Maybe we need to revisit? @jhadvig, @spadgett, @vojtechszocs, WDYT?

IMO it should be "Console Plugins" everywhere. That's the only kind of plugin we've ever had an external API for. "Static plugins" were always an internal thing, so there's not a need to differentiate between them for users. I think putting "Dynamic" in the label raises more questions than it answers for most users. Also "Console Plugin" matches the CRD kind.

IIRC, we went with Dynamic Plugins so as not to conflate the functionality with the resource. One could argue that subtlety is lost on users however...

Docs uses "Dynamic Plugins": https://docs.openshift.com/container-platform/4.17/web_console/dynamic-plugin/overview-dynamic-plugin.html

spadgett commented 17 hours ago

IIRC, we went with Dynamic Plugins so as not to conflate the functionality with the resource. One could argue that subtlety is lost on users however...

To me, this could create more confusion because it sounds like they're two different things. There are also other kinds of plugins on the platform (for instance, network plugins or CLI plugins). The most important differentiator is that it's a console plugin.

Docs uses "Dynamic Plugins": https://docs.openshift.com/container-platform/4.17/web_console/dynamic-plugin/overview-dynamic-plugin.html

I'd update the docs as well to use "Console Plugins."

rhamilto commented 17 hours ago

I added a story for 4.19.

openshift-ci-robot commented 14 hours ago

/retest-required

Remaining retests: 0 against base HEAD ea76ee699113d251e74be989e6ca9613e717db33 and 2 for PR HEAD 16c6473bd04889d230ee2d25320a98ce66707129 in total

openshift-ci[bot] commented 11 hours ago

@rhamilto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 16c6473bd04889d230ee2d25320a98ce66707129 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 hours ago

/retest-required

Remaining retests: 0 against base HEAD d87887934af62b7306ab458208b0002c009aa40c and 1 for PR HEAD 16c6473bd04889d230ee2d25320a98ce66707129 in total