openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

[release-4.16] OCPBUGS-44806: Don't request user settings configmap if no user has been loaded. #14522

Open openshift-cherrypick-robot opened 1 day ago

openshift-cherrypick-robot commented 1 day ago

This is an automated cherry-pick of #14482

/assign TheRealJon

openshift-ci-robot commented 1 day ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-44450 has been cloned as Jira Issue OCPBUGS-44806. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-44806: Don't request user settings configmap if no user has been loaded.

In response to [this](https://github.com/openshift/console/pull/14522): >This is an automated cherry-pick of #14482 > >/assign TheRealJon Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 day ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-44806, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14522): >This is an automated cherry-pick of #14482 > >/assign TheRealJon Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanpzhan commented 1 day ago

Checked on cluster launched against the pr, there was not 403 error in console pod log when normal user login console. /label qe-approved /label cherry-pick-approved

jhadvig commented 3 hours ago

/approve /jira refresh /retest

openshift-ci-robot commented 3 hours ago

@jhadvig: This pull request references Jira Issue OCPBUGS-44806, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-44450](https://issues.redhat.com//browse/OCPBUGS-44450) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-44450](https://issues.redhat.com//browse/OCPBUGS-44450) targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z * bug has dependents

Requesting review from QA contact: /cc @yapei

In response to [this](https://github.com/openshift/console/pull/14522#issuecomment-2493607414): >/approve >/jira refresh >/retest Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/openshift/console/blob/release-4.16/frontend/OWNERS)~~ [jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 hours ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).