openshift / console

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
401 stars 613 forks source link

[release-4.13] OCPBUGS-36561: Increase login flow state paramater lenth/entropy #14524

Open jhadvig opened 1 day ago

jhadvig commented 1 day ago

Manual backport of https://github.com/openshift/console/pull/14483

openshift-ci-robot commented 1 day ago

@jhadvig: This pull request references Jira Issue OCPBUGS-36561, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/console/pull/14524): >Manual backport of https://github.com/openshift/console/pull/14483 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/auth/OWNERS](https://github.com/openshift/console/blob/release-4.12/pkg/auth/OWNERS)~~ [jhadvig] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 22 hours ago

@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console b645d115c9fef3a4aa629f5d365d3ec77a79d57c link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yanpzhan commented 11 hours ago

Checked on cluster launched against the pr, accessed console url, checked "state" parameter in login redirect url, it's 16 bytes. /label qe-approved /label cherry-pick-approved

openshift-ci-robot commented 11 hours ago

@jhadvig: This pull request references Jira Issue OCPBUGS-36561, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/console/pull/14524): >Manual backport of https://github.com/openshift/console/pull/14483 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fconsole). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.