search

openshift / crd-schema-checker

Tools to check CRD schemas for compatibility and best practices
Apache License 2.0
21 stars 9 forks source link

OCPBUGS-41261: NoNewRequiredFields comparator should use fldPath instead of simpleLocation #32

Closed atiratree closed 2 months ago

atiratree commented 2 months ago

as there can be multiple walks over a single simpleLocation for different sources of required

openshift-ci-robot commented 2 months ago

@atiratree: This pull request references Jira Issue OCPBUGS-41261, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/crd-schema-checker/pull/32): >as there can be multiple walks over a single simpleLocation for different sources of required Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcrd-schema-checker). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 2 months ago

/jira refresh /retest

openshift-ci-robot commented 2 months ago

@atiratree: This pull request references Jira Issue OCPBUGS-41261, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
In response to [this](https://github.com/openshift/crd-schema-checker/pull/32#issuecomment-2364353057): >/jira refresh >/retest Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcrd-schema-checker). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
JoelSpeed commented 2 months ago

/lgtm

/hold I have a call with @deads2k later today, will check if he wants to review before this merges

deads2k commented 2 months ago

/hold cancel

JoelSpeed commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/crd-schema-checker/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@atiratree: Jira Issue OCPBUGS-41261: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41261 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/crd-schema-checker/pull/32): >as there can be multiple walks over a single simpleLocation for different sources of required Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcrd-schema-checker). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.