search

openshift / enhancements

Enhancements tracking repository for OKD
Apache License 2.0
179 stars 469 forks source link

enhancements/machine-config: updates to pin and preload images #1642

Closed hexfusion closed 3 months ago

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign suleymanakbas91 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/enhancements/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cgwalters commented 4 months ago

Also xref https://github.com/containers/podman/issues/22785 which proposes a similar feature in podman, driven primarily by podman-systemd as the declarative state.

openshift-bot commented 3 months ago

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale. Stale proposals rot after an additional 7d of inactivity and eventually close. Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 months ago

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten. Rotten proposals close after an additional 7d of inactivity. Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 months ago

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen. Mark the proposal as fresh by commenting /remove-lifecycle rotten. Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 3 months ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/enhancements/pull/1642#issuecomment-2249100230): >Rotten enhancement proposals close after 7d of inactivity. > >See https://github.com/openshift/enhancements#life-cycle for details. > >Reopen the proposal by commenting `/reopen`. >Mark the proposal as fresh by commenting `/remove-lifecycle rotten`. >Exclude this proposal from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.