search

openshift / enhancements

Enhancements tracking repository for OKD
Apache License 2.0
179 stars 469 forks source link

Improve YAML header parsing #1647

Closed jupierce closed 4 months ago

jupierce commented 4 months ago

The previous implementation required yaml doc separator to ignore everything after the second delimiter. I believe the YAML standard expects subsequent documents to also be valid YAML. This change truncates the markdown prior to trying to parse the YAML header.

openshift-ci[bot] commented 4 months ago

@jupierce: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/enhancements/blob/master/OWNERS)~~ [soltysh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment