search

openshift / enhancements

Enhancements tracking repository for OKD
Apache License 2.0
179 stars 469 forks source link

Add enhancement for supporting user namespaces #1649

Closed haircommander closed 2 months ago

haircommander commented 4 months ago

related https://issues.redhat.com/browse/OCPNODE-2337 cc @rphillips @mrunalp

haircommander commented 4 months ago

/hold

@deads2k is on vacation and should review this. I'm opening it for preliminary review though

haircommander commented 4 months ago

SCC piece https://github.com/openshift/api/pull/1939

haircommander commented 4 months ago

TPNU piece https://github.com/openshift/api/pull/1940

haircommander commented 3 months ago

/hold cancel

I chatted with @deads2k on slack, he's okay with the piece I was waiting for his council on

rphillips commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/enhancements/blob/master/OWNERS)~~ [rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
haircommander commented 3 months ago

/hold

haircommander commented 3 months ago

for API and auth team reviews

haircommander commented 3 months ago

/hold cancel

haircommander commented 2 months ago

updated @deads2k @liouk ! thanks for your reviews, PTAL

liouk commented 2 months ago

/lgtm

Holding for @deads2k to finish his review and approve.

/hold

deads2k commented 2 months ago

/lgtm /hold cancel

openshift-ci[bot] commented 2 months ago

@haircommander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).