search

openshift / enhancements

Enhancements tracking repository for OKD
Apache License 2.0
179 stars 469 forks source link

WIP: OCPNODE-2462 - Split Filesystem OCP Enhancement #1657

Closed kannon92 closed 9 hours ago

kannon92 commented 3 months ago

This is a OCP enhancement for enabling KEP-4191 in openshift.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ashcrow for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/enhancements/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rphillips commented 3 months ago

Technically, I think we should reserve, IMAGE_STORE as a partition label. This document could go into this. The script can attempt to mount by label the IMAGE_STORE partition.

The split-filesystem.sh script would:

Node Team's scope starts at IMAGE_STORE partition label... This partition label could be setup by CAPI or by documentation or by some other external entity.

rphillips commented 3 months ago

We are going to take this enhancement to a meeting to discuss further design.

openshift-bot commented 2 months ago

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale. Stale proposals rot after an additional 7d of inactivity and eventually close. Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

kwilczynski commented 2 months ago

/remove-lifecycle stale

openshift-ci[bot] commented 1 month ago

@kannon92: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 weeks ago

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale. Stale proposals rot after an additional 7d of inactivity and eventually close. Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 week ago

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten. Rotten proposals close after an additional 7d of inactivity. Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 9 hours ago

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen. Mark the proposal as fresh by commenting /remove-lifecycle rotten. Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 9 hours ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/enhancements/pull/1657#issuecomment-2453235169): >Rotten enhancement proposals close after 7d of inactivity. > >See https://github.com/openshift/enhancements#life-cycle for details. > >Reopen the proposal by commenting `/reopen`. >Mark the proposal as fresh by commenting `/remove-lifecycle rotten`. >Exclude this proposal from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.