openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

Adds a secret checksum annotation to deployment #127

Closed DhritiShikhar closed 2 years ago

DhritiShikhar commented 2 years ago

Issue Link -> CFE-366

Changes:

  1. Adds a watch for target secret
  2. Creates hash of target secret data
  3. Adds hash to deployment's annotation Example: externaldns.olm.openshift.io/credentials-secret-hash: 72ddc0c540ab3a290e138726940591debf14c581
lmzuccarelli commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

@DhritiShikhar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
lmzuccarelli commented 2 years ago

/lgtm

lmzuccarelli commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DhritiShikhar, lmzuccarelli, sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [lmzuccarelli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alebedev87 commented 2 years ago

/label tide/merge-method-squash

alebedev87 commented 2 years ago

/label docs-approved /label px-approved /label qe-approved