Use operator-sdk to generate OLM bundle

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.

Apache License 2.0

26 stars 33 forks source link

Use operator-sdk to generate OLM bundle #128

Closed alebedev87 closed 2 years ago

alebedev87 commented 2 years ago

The main file to verify is bundle/manifests/external-dns-operator.clusterserviceversion.yaml. It now has all the RBAC embedded and CR examples for all the providers.

Some notes:

volume and volume mount used for the webhook certificates are now added only for non OLM deployment. OLM injects them automatically.
webhook service (config/webhook/service.yaml) was scaffolded by operator-sdk but doesn't need to be in the bundle as again OLM will generate a webhook service. However it has to be in bundle/manifests/ during the bundle generation, otherwise webhookdefintions of CSV won't be generated properly. That's why it has been added to the ignore files.

alebedev87 commented 2 years ago

/retest

alebedev87 commented 2 years ago

/retest

alebedev87 commented 2 years ago

/assign @sherine-k

alebedev87 commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 2 years ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).