search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

Credentials for AWS provider to be consumed as a volume mount #130

Closed DhritiShikhar closed 2 years ago

DhritiShikhar commented 2 years ago

Issue -> https://issues.redhat.com/browse/CFE-368

openshift-ci[bot] commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

DhritiShikhar commented 2 years ago

/test e2e-aws-operator

arjunrn commented 2 years ago

/label tide/merge-method-squash

darshan-nagaraj commented 2 years ago

/lgtm

DhritiShikhar commented 2 years ago

/test verify

alebedev87 commented 2 years ago

/remove-label tide/merge-method-squash

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, DhritiShikhar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alebedev87 commented 2 years ago

/label docs-approved

Based on https://github.com/openshift/external-dns-operator/pull/130#issuecomment-1113313154

alebedev87 commented 2 years ago

/assign @quarterpin

alebedev87 commented 2 years ago

/label px-approved

quarterpin commented 2 years ago

/label qe-approved

openshift-ci[bot] commented 2 years ago

@DhritiShikhar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).