use public golang 1.17 for the local builds

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.

Apache License 2.0

26 stars 33 forks source link

use public golang 1.17 for the local builds #138

Closed alebedev87 closed 2 years ago

alebedev87 commented 2 years ago

Why this change?

The base image from Dockerfile is used for the local builds only. CI and CPaaS (product release) use RHEL based go 1.17 images for the builds and runtime.
ubi8/go-toolset is slow in its release cycle, 1.17 is still not in the latest image while 1.18 is already out for more than a month. It took them 8 month (tags dates, 1.16 releases) to release the first 1.16 version, so I don't expect this to be any faster for 1.17.

alebedev87 commented 2 years ago

/assign @dbaker-rh

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dbaker-rh commented 2 years ago

Please do not use unqualified container image names.

Using the implicit docker hub source has rate limit considerations.

The image in question is debian based - I propose local builds should be done in the same environment (so, rhel/ubi) as production builds.

That said, this isn't my decision to approve/deny so I'll unassign myself from the PR.

alebedev87 commented 2 years ago

/retest

alebedev87 commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

alebedev87 commented 2 years ago

/assign @thejasn

thejasn commented 2 years ago

/lgtm

thejasn commented 2 years ago

/label docs-approved /label qe-approved /lable px-approved

alebedev87 commented 2 years ago

/label px-approved