openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
26 stars 33 forks source link

Add v1beta1 version #141

Closed alebedev87 closed 2 years ago

alebedev87 commented 2 years ago

What's inside:

Notes:

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alebedev87 commented 2 years ago

/assign @Miciah @arjunrn

alebedev87 commented 2 years ago

@Miciah : no, the move of main.go out of cmd/ is not directly related to the migration to v1beta1. It's the new kubebuilder project layout: before it was scaffolding into cmd/, now it's putting main.go in the root of the repository. I updated operator-sdk version meanwhile and the newer version could not scaffold the new api if main.go was not in the root.

alebedev87 commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
alebedev87 commented 2 years ago

/assign @quarterpin

quarterpin commented 2 years ago

/label qe-approved

Miciah commented 2 years ago

/lgtm

alebedev87 commented 2 years ago

/label docs-approved /label px-approved