Closed alebedev87 closed 2 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alebedev87
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign @Miciah @arjunrn
@Miciah : no, the move of main.go
out of cmd/
is not directly related to the migration to v1beta1
. It's the new kubebuilder project layout: before it was scaffolding into cmd/
, now it's putting main.go
in the root of the repository. I updated operator-sdk
version meanwhile and the newer version could not scaffold the new api if main.go
was not in the root.
/retest
@alebedev87: all tests passed!
Full PR test history. Your PR dashboard.
/assign @quarterpin
/label qe-approved
/lgtm
/label docs-approved /label px-approved
What's inside:
api/v1beta1/
v1beta1
is identical tov1alpha1
v1beta1
is the storage version nowapi/v1beta1/
, it handles onlyv1beta1
(v1alpha1
objects are also served by API, see the notes)v1beta1
v1beta1
samples addedv1beta1
, one test is added for the check ofv1alpha1
resourcesNotes:
v1beta1
only. This works out even for the objects created before the upgrade to this version of the operator. Because the version which is being watched/used is the preferred(has to do with the version priority too), so API will take care of making the conversion. This is different from where the objects are stored though. The objects created before the new version was added to CRD are still stored as the previous version until they are touched (patch/update).stable
channel is done in a followup PR: https://github.com/openshift/external-dns-operator/pull/146. The reason is to not block other PR as this change needs the CI update (bundle installation).