search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
26 stars 33 forks source link

ensure deployment: check volumes, volumemounts and env variable for changes #150

Closed alebedev87 closed 2 years ago

alebedev87 commented 2 years ago

Make sure volumes, volumemounts and environment variables are checked for changes and propagated to the operand deployment.

Should help https://github.com/openshift/external-dns-operator/pull/149

alebedev87 commented 2 years ago

/assign @DhritiShikhar

DhritiShikhar commented 2 years ago

PR looks good but PR CI e2e fails.

DhritiShikhar commented 2 years ago

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, DhritiShikhar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alebedev87 commented 2 years ago

/label docs-approved /label px-approved /label qe-approved

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci[bot] commented 2 years ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).